r110405 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110404‎ | r110405 | r110406 >
Date:16:43, 31 January 2012
Author:gregchiasson
Status:ok
Tags:aft 
Comment:
AFT5 - Fix the way article diff links are built, to work in non-default namespaces, per comments on r109844
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -42,7 +42,6 @@
4343 $params['limit'],
4444 ( $params['continue'] !== 'null' ? $params['continue'] : null )
4545 );
46 -
4746 foreach ( $feedback as $record ) {
4847 $html .= $this->renderFeedback( $record );
4948 $length++;
@@ -191,7 +190,7 @@
192191 'af_is_deleted', 'af_needs_oversight',
193192 '(SELECT COUNT(*) FROM ' . $dbr->tableName( 'revision' ) . ' WHERE rev_id > af_revision_id AND rev_page = ' . ( integer ) $pageId . ') AS age',
194193 'CONVERT(af_helpful_count, SIGNED) - CONVERT(af_unhelpful_count, SIGNED) AS net_helpfulness',
195 - 'page_latest', 'af_revision_id', 'page_title',
 194+ 'page_latest', 'af_revision_id', 'page_title', 'page_namespace',
196195 'rating.aa_response_boolean AS rating'
197196 ),
198197 array( 'af_id' => $ids ),
@@ -320,7 +319,7 @@
321320 ) );
322321 if( $record[0]->age > 0 ) {
323322 $details .= Linker::link(
324 - Title::newFromText( $record[0]->page_title ),
 323+ Title::newFromRow( $record[0] ),
325324 wfMessage( 'articlefeedbackv5-updates-since', $record[0]->age )->escaped(),
326325 array(),
327326 array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109844AFT5 feedback page - HTML fixes, and resolve a TODO on the 'edits since' link.gregchiasson19:06, 23 January 2012

Status & tagging log