r110391 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110390‎ | r110391 | r110392 >
Date:14:47, 31 January 2012
Author:amire80
Status:ok
Tags:core, i18nreview 
Comment:
"isset( $forms[2] )" is not needed - plural is filled in preConvertPlural if dual is not provided.
Modified paths:
  • /trunk/phase3/languages/classes/LanguageHe.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/classes/LanguageHe.php
@@ -61,8 +61,8 @@
6262
6363 if ( $count == '1' ) {
6464 return $forms[0]; // Singular
65 - } elseif ( $count == '2' && isset( $forms[2] ) ) {
66 - return $forms[2]; // Dual
 65+ } elseif ( $count == '2' ) {
 66+ return $forms[2]; // Dual or plural if dual is not provided (filled in preConvertPlural)
6767 } else {
6868 return $forms[1]; // Plural
6969 }

Status & tagging log