r110374 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110373‎ | r110374 | r110375 >
Date:10:22, 31 January 2012
Author:ialex
Status:ok
Tags:
Comment:
Added missing __METHOD__ parameter to DatabaseBase::selectField() calls in ExternalStoreDB
Modified paths:
  • /trunk/phase3/includes/ExternalStoreDB.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ExternalStoreDB.php
@@ -120,12 +120,12 @@
121121 wfDebug( "ExternalStoreDB::fetchBlob cache miss on $cacheID\n" );
122122
123123 $dbr =& $this->getSlave( $cluster );
124 - $ret = $dbr->selectField( $this->getTable( $dbr ), 'blob_text', array( 'blob_id' => $id ) );
 124+ $ret = $dbr->selectField( $this->getTable( $dbr ), 'blob_text', array( 'blob_id' => $id ), __METHOD__ );
125125 if ( $ret === false ) {
126126 wfDebugLog( 'ExternalStoreDB', "ExternalStoreDB::fetchBlob master fallback on $cacheID\n" );
127127 // Try the master
128128 $dbw =& $this->getMaster( $cluster );
129 - $ret = $dbw->selectField( $this->getTable( $dbw ), 'blob_text', array( 'blob_id' => $id ) );
 129+ $ret = $dbw->selectField( $this->getTable( $dbw ), 'blob_text', array( 'blob_id' => $id ), __METHOD__ );
130130 if( $ret === false) {
131131 wfDebugLog( 'ExternalStoreDB', "ExternalStoreDB::fetchBlob master failed to find $cacheID\n" );
132132 }

Status & tagging log