r110370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110369‎ | r110370 | r110371 >
Date:10:00, 31 January 2012
Author:raymond
Status:ok
Tags:
Comment:
r110330: Consistency tweaks in preparation for adding extension to translatewiki.net
* Message tweaks: no Title Case in sentences
* Remove identical special page alias
* Add a fixme for a bumber in a message. I have not installed SMW so I cannot test it properly.
Modified paths:
  • /trunk/extensions/SemanticPageSeries/SemanticPageSeries.alias.php (modified) (history)
  • /trunk/extensions/SemanticPageSeries/SemanticPageSeries.i18n.php (modified) (history)
  • /trunk/extensions/SemanticPageSeries/includes/SPSSpecialSeriesEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticPageSeries/SemanticPageSeries.i18n.php
@@ -14,8 +14,8 @@
1515 'spssuccess' => '$1 pages will be created.',
1616 'spserror' => 'An error occurred',
1717
18 - 'spserror_diffnotsupported' => 'The Diff action is not supported for page series.',
19 - 'spserror_previewnotsupported' => 'The Preview action is not supported for page series.',
 18+ 'spserror_diffnotsupported' => 'The diff action is not supported for page series.',
 19+ 'spserror_previewnotsupported' => 'The preview action is not supported for page series.',
2020 'spserror_noiteratorname' => 'No iterator name given.',
2121 'spserror_iteratorunknown' => 'Iterator "$1" does not exist.',
2222 'spserror_noformname' => 'No form name given.',
Index: trunk/extensions/SemanticPageSeries/includes/SPSSpecialSeriesEdit.php
@@ -56,7 +56,7 @@
5757 $keys = array_keys( $get );
5858
5959 $wgOut->setPageTitle( wfMsg( 'spssuccesstitle', $keys[0] ) );
60 - $wgOut->addHTML( wfMsg( 'spssuccess', $get[$keys[0]] ) );
 60+ $wgOut->addHTML( wfMsg( 'spssuccess', $get[$keys[0]] ) ); // FIXME: per message doc this is a number. Therefor it needs a run through $wgLang->formatNum(). Maybe PLURAL too?
6161 } else {
6262
6363 // no action requested, show form
Index: trunk/extensions/SemanticPageSeries/SemanticPageSeries.alias.php
@@ -13,6 +13,6 @@
1414 /** English
1515 */
1616 $specialPageAliases['en'] = array(
17 - 'SeriesEdit' => array( 'SeriesEdit', 'SeriesEdit' ),
 17+ 'SeriesEdit' => array( 'SeriesEdit' ),
1818 );
1919

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110330Creating new extensionfoxtrott21:31, 30 January 2012

Status & tagging log