r110359 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110358‎ | r110359 | r110360 >
Date:06:57, 31 January 2012
Author:catrope
Status:ok
Tags:
Comment:
Fix some missing var keywords
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -117,8 +117,8 @@
118118 } );
119119
120120 $( '.articleFeedbackv5-sort-link' ).bind( 'click', function( e ) {
121 - id = $.articleFeedbackv5special.stripID( this, 'articleFeedbackv5-special-sort-' );
122 - oldId = $.articleFeedbackv5special.listControls.sort;
 121+ var id = $.articleFeedbackv5special.stripID( this, 'articleFeedbackv5-special-sort-' ),
 122+ oldId = $.articleFeedbackv5special.listControls.sort;
123123
124124 // set direction = desc...
125125 $.articleFeedbackv5special.listControls.sort = id;
@@ -144,7 +144,7 @@
145145 } );
146146
147147 $( '.articleFeedbackv5-permalink' ).live( 'click', function( e ) {
148 - id = $.articleFeedbackv5special.stripID( this, 'articleFeedbackv5-permalink-' );
 148+ var id = $.articleFeedbackv5special.stripID( this, 'articleFeedbackv5-permalink-' );
149149 $.articleFeedbackv5special.listControls.filter = 'id';
150150 $.articleFeedbackv5special.listControls.filterValue = id;
151151 $.articleFeedbackv5special.listControls.continue = null;
@@ -252,8 +252,8 @@
253253 // {{{ drawSortArrow
254254
255255 $.articleFeedbackv5special.drawSortArrow = function() {
256 - id = $.articleFeedbackv5special.listControls.sort;
257 - dir = $.articleFeedbackv5special.listControls.sortDirection;
 256+ var id = $.articleFeedbackv5special.listControls.sort,
 257+ dir = $.articleFeedbackv5special.listControls.sortDirection;
258258
259259 $( '.articleFeedbackv5-sort-arrow' ).hide();
260260 $( '.articleFeedbackv5-sort-link' ).removeClass( 'sort-active' );

Status & tagging log