r110308 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110307‎ | r110308 | r110309 >
Date:17:36, 30 January 2012
Author:hashar
Status:ok
Tags:
Comment:
rv r87948 "fix backtrace on SQL error"

Looks unneeded nowaday. Backtrace is correctly appended to HTML output
or CLI output when $wgShowDBErrorBacktrace is true.

Not sure what it was supposed to fix.
Modified paths:
  • /trunk/phase3/includes/db/DatabaseError.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseError.php
——@@ -272,10 +272,6 @@
273273 "Query: $sql\n" .
274274 "Function: $fname\n" .
275275 "Error: $errno $error\n";
276 - global $wgShowDBErrorBacktrace;
277 - if( $wgShowDBErrorBacktrace ) {
278 - $message .= $this->getTraceAsString();
279 - }
280276 parent::__construct( $db, $message );
281277
282278 $this->error = $error;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87948fix backtrace on SQL error...hashar07:05, 13 May 2011

Status & tagging log