r110292 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110291‎ | r110292 | r110293 >
Date:15:03, 30 January 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Second try at fixing it
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)
  • /trunk/extensions/Translate/ffs/MediaWikiExtensions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -53,7 +53,7 @@
5454 /// Get the namespace where all the messages of this group belongs.
5555 public function getNamespace() { return $this->namespace; }
5656 /// Set the namespace where all the messages of this group belongs.
57 - public function setNamespace() { return $this->namespace; }
 57+ public function setNamespace( $ns ) { $this->namespace = $ns; }
5858
5959
6060 /**
Index: trunk/extensions/Translate/ffs/MediaWikiExtensions.php
@@ -55,7 +55,7 @@
5656 $group = ExtensionMessageGroup::factory( $info['name'], $id );
5757 $group->setMessageFile( $info['file'] );
5858 $group->setPath( $this->path );
59 - $group->namespaces = $this->namespaces;
 59+ $group->setNamespace( $this->namespace );
6060
6161 if ( isset( $info['prefix'] ) ) {
6262 $mangler = new StringMatcher( $info['prefix'], $info['mangle'] );

Status & tagging log