r110289 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110288‎ | r110289 | r110290 >
Date:13:54, 30 January 2012
Author:siebrand
Status:ok
Tags:core 
Comment:
Revert r110285, r110286. No new features in core during slush.

Consider recommit after 1.19 is branched, and please add hooks.txt documentation, too.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -4164,21 +4164,7 @@
41654165 * @return Bool
41664166 */
41674167 public function isKnown() {
4168 - $isKnown = null;
4169 -
4170 - /**
4171 - * Allows overriding default behaviour for determining if a page exists.
4172 - * If $isKnown is kept as null, regular checks happen. If it's
4173 - * a boolean, this value is returned by the isKnown method.
4174 - *
4175 - * @since 1.19
4176 - *
4177 - * @param Title $title
4178 - * @param boolean|null $isKnown
4179 - */
4180 - wfRunHooks( 'TitleIsKnown', array( $this, &$isKnown ) );
4181 -
4182 - return is_null( $isKnown ) ? ( $this->isAlwaysKnown() || $this->exists() ) : $isKnown;
 4168+ return $this->isAlwaysKnown() || $this->exists();
41834169 }
41844170
41854171 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110285add hook that allows changing the check to see if a page exists or notjeroendedauw12:52, 30 January 2012
r110286follow up to r110285, fixed accidental newlinejeroendedauw12:54, 30 January 2012

Status & tagging log