r110248 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110247‎ | r110248 | r110249 >
Date:18:08, 29 January 2012
Author:ashley
Status:ok
Tags:
Comment:
SocialProfile: fix bug in Special:GenerateTopUsersReport -- I'm sure I had a reason why I added that -1 there, but it's causing "non-string key given" exceptions now, as null is passed to Language::getMonthName()
Modified paths:
  • /trunk/extensions/SocialProfile/UserStats/GenerateTopUsersReport.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserStats/GenerateTopUsersReport.php
@@ -88,7 +88,7 @@
8989 '-' . $wgContLang->date( wfTimestampNow() );
9090 } elseif ( $period == 'monthly' ) {
9191 $date = getdate(); // It's a PHP core function
92 - $period_title = $wgContLang->getMonthName( $date['mon'] - 1 ) .
 92+ $period_title = $wgContLang->getMonthName( $date['mon'] ) .
9393 ' ' . $date['year'];
9494 }
9595

Status & tagging log