r110227 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110226‎ | r110227 | r110228 >
Date:05:37, 29 January 2012
Author:jeroendedauw
Status:ok
Tags:
Comment:
this is no longer a guideline afaik
Modified paths:
  • /trunk/phase3/docs/design.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/design.txt
@@ -89,10 +89,6 @@
9090 things will break. New code should use the standard method of setting
9191 visibilities as normal.
9292
93 - - Member variables are generally "mXxx" to distinguish them. This should make
94 - it easier to spot errors of forgetting the required "$this->", which PHP
95 - will happily accept by creating a new local variable rather than complaining.
96 -
9793 - Globals are particularly evil in PHP; it sets a lot of them automatically
9894 from cookies, query strings, and such, leading to namespace conflicts; when
9995 a variable name is used in a function, it is silently declared as a new

Status & tagging log