r110181 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110180‎ | r110181 | r110182 >
Date:22:57, 27 January 2012
Author:aaron
Status:ok
Tags:
Comment:
Killed the metric arseload of test folders that were being leaked and killing jenkins
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php
@@ -445,6 +445,7 @@
446446 "$base/local-thumb/3/3a/Foobar.jpg/640px-Foobar.jpg",
447447 "$base/local-thumb/3/3a/Foobar.jpg/120px-Foobar.jpg",
448448
 449+ "$base/local-public/0/09/Bad.jpg",
449450 "$base/local-thumb/0/09/Bad.jpg",
450451
451452 "$base/local-public/math/f/a/5/fa50b8b616463173474302ca3e63586b.png",
@@ -464,7 +465,9 @@
465466 foreach ( $files as $file ) {
466467 $tmp = $file;
467468 while ( $tmp = FileBackend::parentStoragePath( $tmp ) ) {
468 - $backend->clean( array( 'dir' => $tmp ) );
 469+ if ( !$backend->clean( array( 'dir' => $tmp ) )->isOK() ) {
 470+ break;
 471+ }
469472 }
470473 }
471474 }

Status & tagging log