r110168 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r110167
|
r110168
|
r110169
>
Date:
21:06, 27 January 2012
Author:
platonides
Status:
ok
Tags:
Comment:
The if should check $commentText, not $f, which is always set in this branch.
Modified paths:
/trunk/phase3/maintenance/importImages.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/maintenance/importImages.php
—
—
@@ -206,7 +206,7 @@
207
207
echo( " No comment file with extension {$commentExt} found for {$file}, using default comment. " );
208
208
} else {
209
209
$commentText = file_get_contents( $f );
210
- if ( !$f ) {
210
+ if ( !$commentText ) {
211
211
echo( " Failed to load comment file {$f}, using default comment. " );
212
212
}
213
213
}
Status & tagging log
21:17, 27 January 2012
😂
(
talk
|
contribs
)
changed the
status
of r110168
[
removed:
new
added:
ok]