r110164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110163‎ | r110164 | r110165 >
Date:20:40, 27 January 2012
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow-up r105244, remove dummy else branch, it was there
probably from being $item['contents'] = bin2hex($item['contents']);
before.
Modified paths:
  • /trunk/extensions/TorBlock/ASN1Parser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TorBlock/ASN1Parser.php
——@@ -114,10 +114,9 @@
115115 * project or crypto/objects/obj_dat.txt (where hexadecimal
116116 * data is available )
117117 */
118 - $item['contents'] = $item['contents'];
119 - } else {
120118 $item['contents'] = $item['contents'];
121119 }
 120+ /* Else, we leave contents as binary data */
122121
123122 $result[] = $item;
124123 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105244Parser of ASN1 syntax used in RSA keys.platonides23:28, 5 December 2011

Comments

#Comment by Reedy (talk | contribs)   20:45, 27 January 2012

You've still got one that's assigning itself to itself...

Maybe use // No change

#Comment by Platonides (talk | contribs)   21:24, 27 January 2012

I know, it's there on purpose, in case the comment above might get implemented one day.

Status & tagging log