r110156 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r110155
|
r110156
|
r110157
>
Date:
19:36, 27 January 2012
Author:
gregchiasson
Status:
ok
Tags:
Comment:
AFT5 - Followup to
r110132
, fixes untranslated percentage in span tag, and uses Html library instead of literals to build the markup.
Modified paths:
/trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
—
—
@@ -138,7 +138,9 @@
139
139
140
140
if ( $found ) {
141
141
$class = $found > 50 ? 'positive' : 'negative';
142
- $span = "<span class='stat-marker $class'>$found%</span>";
142
+ $span = Html::rawElement( 'span', array(
143
+ 'class' => "stat-marker $class"
144
+ ), wfMsg( 'percent', $found ) );
143
145
$out->addHtml(
144
146
Html::openElement(
145
147
'div',
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r110132
Fixes issues raised in commits from last night:...
gregchiasson
15:57, 27 January 2012
Status & tagging log
22:05, 27 January 2012
Reedy
(
talk
|
contribs
)
changed the
status
of r110156
[
removed:
new
added:
ok]