r110119 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110118‎ | r110119 | r110120 >
Date:13:09, 27 January 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
fixed failing var ref
Modified paths:
  • /trunk/extensions/Maps/Maps_Settings.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/GoogleMaps3/jquery.googlemap.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps_Settings.php
@@ -221,6 +221,7 @@
222222 $egMapsGMaps3AutoInfoWindows = false;
223223
224224 # Array. Layers to load by default.
 225+ # traffic and bicycling
225226 $egMapsGMaps3Layers = array();
226227
227228 # Integer. Default tilt when using Google Maps.
Index: trunk/extensions/Maps/includes/services/GoogleMaps3/jquery.googlemap.js
@@ -115,7 +115,7 @@
116116 var kmlLayer = new google.maps.KmlLayer(
117117 options.gkml[i],
118118 {
119 - map: map,
 119+ map: this.map,
120120 preserveViewport: !options.kmlrezoom
121121 }
122122 );
@@ -124,7 +124,7 @@
125125 // If there are any non-Google KML/KMZ layers, load the geoxml library and use it to add these layers.
126126 if ( options.kml.length != 0 ) {
127127 mw.loader.using( 'ext.maps.gm3.geoxml', function() {
128 - var geoXml = new geoXML3.parser( { map: map, zoom: options.kmlrezoom } );
 128+ var geoXml = new geoXML3.parser( { map: this.map, zoom: options.kmlrezoom } );
129129
130130 for ( i = options.kml.length - 1; i >= 0; i-- ) {
131131 geoXml.parse( options.kml[i] );