r110117 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110116‎ | r110117 | r110118 >
Date:12:22, 27 January 2012
Author:j
Status:ok
Tags:miscextensions 
Comment:
dont run pass 2 if pass 1 failed
Modified paths:
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php
@@ -109,7 +109,7 @@
110110 if( isset( $options['twopass'] ) ){
111111 // ffmpeg requires manual two pass
112112 $status = $this->ffmpegEncode( $options, 1 );
113 - if( $status ){
 113+ if( $status && !is_string($status) ){
114114 $status = $this->ffmpegEncode( $options, 2 );
115115 }
116116 } else {

Status & tagging log