r110116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110115‎ | r110116 | r110117 >
Date:12:03, 27 January 2012
Author:jeroendedauw
Status:ok
Tags:
Comment:
type hinting and docs
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_Utils.php
@@ -825,15 +825,20 @@
826826 *
827827 * @author Solitarius
828828 * @since 2.4
 829+ *
 830+ * @param EditPage $editpage
 831+ * @param WebRequest $request
 832+ *
 833+ * @return true
829834 */
830 - public static function showFormPreview( $editpage, $request ) {
 835+ public static function showFormPreview( EditPage $editpage, WebRequest $request ) {
831836 global $wgOut, $sfgFormPrinter;
832837
833838 wfDebug( __METHOD__ . ": enter.\n" );
834839 wfProfileIn( __METHOD__ );
835840
836841 // Exit if we're not in preview mode.
837 - if ( ! $editpage->preview ) {
 842+ if ( !$editpage->preview ) {
838843 return true;
839844 }
840845 // Exit if we aren't in the "Form" namespace.

Status & tagging log