r110074 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110073‎ | r110074 | r110075 >
Date:20:20, 26 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Fix calls of implode
Modified paths:
  • /trunk/extensions/ClientSide/ClientSide.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ClientSide/ClientSide.php
@@ -30,7 +30,7 @@
3131 array_shift( $arguments );
3232 }
3333 if ( count( $arguments ) > 0 ) {
34 - return self::tag( 'table', $attributes, implode( $arguments ) );
 34+ return self::tag( 'table', $attributes, implode( '', $arguments ) );
3535 }
3636 return null;
3737 }
@@ -49,7 +49,7 @@
5050 array_shift( $arguments );
5151 }
5252 if ( count( $arguments ) > 0 ) {
53 - return self::tag( 'tr', $attributes, implode( $arguments ) );
 53+ return self::tag( 'tr', $attributes, implode( '', $arguments ) );
5454 }
5555 return null;
5656 }
@@ -163,7 +163,7 @@
164164 $contents = null
165165 ) {
166166 if ( is_array( $contents ) && count( $contents ) > 1 ) {
167 - return Xml::tags( $tag, $attributes, implode( $contents ) );
 167+ return Xml::tags( $tag, $attributes, implode( '', $contents ) );
168168 } else {
169169 return Xml::tags(
170170 $tag, $attributes, $contents, ( $contents !== null )
@@ -313,7 +313,7 @@
314314 ) {
315315 // Arrays
316316 if ( is_array( $value ) ) {
317 - return "'" . self::escape( implode( $value ) ) . "'";
 317+ return "'" . self::escape( implode( '', $value ) ) . "'";
318318 }
319319 // Scalars
320320 if ( is_scalar( $value ) ) {

Status & tagging log