r109968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109967‎ | r109968 | r109969 >
Date:23:31, 24 January 2012
Author:gregchiasson
Status:ok
Tags:aft 
Comment:
AFT5 - html tweak for designers - close a P tag manually instead of having the div do it for us.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -343,6 +343,7 @@
344344 'class' => 'articleFeedbackv5-unhelpful-link'
345345 ), wfMessage( 'articlefeedbackv5-form-helpful-no-label', $record[0]->af_unhelpful_count )->text() );
346346 }
 347+ $footer_links .= Html::closeElement( 'p' );
347348
348349 $footer_links .= Html::element( 'span', array(
349350 'class' => 'articleFeedbackv5-helpful-votes'
@@ -353,7 +354,6 @@
354355 'id' => "articleFeedbackv5-abuse-link-$id",
355356 'class' => 'articleFeedbackv5-abuse-link'
356357 ), wfMessage( 'articlefeedbackv5-form-abuse', $record[0]->af_abuse_count )->text() ) ) : '' )
357 - . Html::closeElement( 'p' )
358358 . Html::closeElement( 'div' );
359359
360360 // Don't render the toolbox if they can't do anything with it.

Status & tagging log