r109954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109953‎ | r109954 | r109955 >
Date:21:20, 24 January 2012
Author:gregchiasson
Status:ok
Tags:
Comment:
Update AFT5 SQL file - comments were invalid, apaprently, and a drop table got missed.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/sql/ArticleFeedbackv5.sql
@@ -10,6 +10,7 @@
1111 DROP TABLE IF EXISTS /*_*/aft_article_revision_feedback_select_rollup;
1212 DROP TABLE IF EXISTS /*_*/aft_article_hits;
1313 DROP TABLE IF EXISTS /*_*/aft_article_feedback_properties;
 14+DROP TABLE IF EXISTS /*_*/aft_article_filter_count;
1415
1516 -- Stores feedback records: "user X submitted feedback on page Y, at time Z"
1617 CREATE TABLE IF NOT EXISTS /*_*/aft_article_feedback (
@@ -99,17 +100,17 @@
100101 PRIMARY KEY (aa_feedback_id, aa_field_id)
101102 ) /*$wgDBTableOptions*/;
102103
 104+-- These next four are rollup tables used by the articlefeedback special page.
 105+-- The revision tables store per-revision numers, as we (in meetings with WMF)
 106+-- agreed that per-revision numbers could be useful in reporting, though
 107+-- they aren't currently used on the feedback page. The page-level ones only
 108+-- count back to wgArticleFeedbackv5RatingLifetime, so they're a rolling window.
103109 --
 110+-- There are tables for ratings and select (ratings includes booleans as well),
 111+-- because while the value of the rating/boolean is important (Rated 3/5), for
 112+-- selects we only want the count for each input, not the value of that input or
 113+-- the sum of the values (which will be numerical option_ids, not meaningful
 114+-- rating values). The queries were sufficiently different that we deemed multiple
104115 --tables worthwhile.
105116 CREATE TABLE IF NOT EXISTS /*_*/aft_article_feedback_ratings_rollup (
106117 arr_page_id integer unsigned NOT NULL,

Status & tagging log