r109850 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109849‎ | r109850 | r109851 >
Date:20:11, 23 January 2012
Author:gregchiasson
Status:ok
Tags:aft 
Comment:
AFT5 feedbak page - add HTMl spans for designers, make active sort label bold, and change sort label to match the mockups.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -64,7 +64,7 @@
6565 'articlefeedbackv5-special-sort-rating' => 'Rating',
6666 'articlefeedbackv5-special-sort-label-before' => 'Sort by:',
6767 'articlefeedbackv5-special-sort-label-after' => '',
68 - 'articlefeedbackv5-special-filter-label-before' => 'Show only:',
 68+ 'articlefeedbackv5-special-filter-label-before' => 'Showing:',
6969 'articlefeedbackv5-special-filter-label-after' => '',
7070 'articlefeedbackv5-special-showing' => '$1 feedback posts on this page', // FIXME: Needs plural support on $1.
7171 'articlefeedbackv5-comment-link' => 'Permalink',
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
@@ -251,4 +251,6 @@
252252 }
253253 .articleFeedbackv5-feedback h3.negative .icon {
254254 background: #bf0a0a url(images/bg_emoticon_negative.png) no-repeat center center;
255 -}
\ No newline at end of file
 255+}
 256+
 257+.sort-active { font-weight: bold; }
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js
@@ -141,11 +141,13 @@
142142 dir = $.articleFeedbackv5special.sortDirection;
143143
144144 $( '.articleFeedbackv5-sort-arrow' ).hide();
 145+ $( '.articleFeedbackv5-sort-link' ).removeClass( 'sort-active' );
145146
146147 $( '#articleFeedbackv5-sort-arrow-' + id ).text(
147148 mw.msg( 'articlefeedbackv5-special-sort-' + dir )
148149 );
149150 $( '#articleFeedbackv5-sort-arrow-' + id ).show();
 151+ $( '#articleFeedbackv5-special-sort-' + id).addClass( 'sort-active' );
150152 }
151153
152154 // Utility method for stripping long IDs down to the specific bits we care about.
Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -178,7 +178,12 @@
179179 'div',
180180 array( 'id' => 'articleFeedbackv5-sort' )
181181 )
 182+ . Html::openElement(
 183+ 'span',
 184+ array( 'class' => 'articleFeedbackv5-sort-label' )
 185+ )
182186 . $this->msg( 'articlefeedbackv5-special-sort-label-before' )->escaped()
 187+ . Html::closeElement( 'span' )
183188 . implode( $this->msg( 'pipe-separator' )->escaped(), $sortLabels )
184189
185190 . $this->msg( 'articlefeedbackv5-special-sort-label-after' )->escaped()
@@ -187,7 +192,12 @@
188193 'div',
189194 array( 'id' => 'articleFeedbackv5-filter' )
190195 )
 196+ . Html::openElement(
 197+ 'span',
 198+ array( 'class' => 'articleFeedbackv5-filter-label' )
 199+ )
191200 . $this->msg( 'articlefeedbackv5-special-filter-label-before' )->escaped()
 201+ . Html::closeElement( 'span' )
192202 . $filterSelect->getHTML()
193203 . $this->msg( 'articlefeedbackv5-special-filter-label-after' )->escaped()
194204 . Html::closeElement( 'div' )

Status & tagging log