r109736 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109735‎ | r109736 | r109737 >
Date:14:21, 22 January 2012
Author:nikerabbit
Status:ok
Tags:i18nreview 
Comment:
Removed unneeded method, moved unsupported methods down
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -267,10 +267,6 @@
268268 $this->mangler = StringMatcher::emptyMatcher();
269269 }
270270
271 - public static function factory( $label, $id ) {
272 - return null;
273 - }
274 -
275271 /**
276272 * Can be overwritten to retun false if something is wrong.
277273 * @return bool
@@ -283,12 +279,6 @@
284280 return null;
285281 }
286282
287 - // Unsupported stuff, just to satisfy the new interface
288 - public function setConfiguration( $conf ) { }
289 - public function getConfiguration() { }
290 -
291 -
292 - public function getFFS() { return null; }
293283 public function getTags( $type = null ) {
294284 $tags = array(
295285 'optional' => $this->optional,
@@ -309,6 +299,11 @@
310300 protected function isSourceLanguage( $code ) {
311301 return $code === $this->getSourceLanguage();
312302 }
 303+
 304+ // Unsupported stuff, just to satisfy the new interface
 305+ public function setConfiguration( $conf ) { }
 306+ public function getConfiguration() { }
 307+ public function getFFS() { return null; }
313308 }
314309
315310 /**

Status & tagging log