r109676 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109675‎ | r109676 | r109677 >
Date:06:18, 21 January 2012
Author:krinkle
Status:ok
Tags:
Comment:
[JSTesting] update QUnit html
* Through all QUnit updates, the html was never updated (only the JS/CSS files). Updating html now according to QUnit documentation. (introduced a new html element used for adding test document elements which are automatically cleaned up. the JS/CSS for QUnit was already referring to this but silently failing)
Modified paths:
  • /trunk/phase3/includes/specials/SpecialJavaScriptTest.php (modified) (history)
  • /trunk/phase3/tests/qunit/index.html (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/index.html
——@@ -131,6 +131,7 @@
132132 </div>
133133 <h2 id="qunit-userAgent"></h2>
134134 <ol id="qunit-tests"></ol>
 135+ <div id="qunit-fixture"></div>
135136
136137 <!-- Scripts inserting stuff here shall remove it themselfs! -->
137138 <div id="content"></div>
Index: trunk/phase3/includes/specials/SpecialJavaScriptTest.php
——@@ -127,6 +127,7 @@
128128 <div id="qunit-testrunner-toolbar"></div>
129129 <div id="qunit-userAgent"></div>
130130 <ol id="qunit-tests"></ol>
 131+<div id="qunit-fixture">test markup, will be hidden</div>
131132 </div>
132133 HTML;
133134 $out->addHtml( $this->wrapSummaryHtml( $summary, 'frameworkfound' ) . $baseHtml );

Sign-offs

UserFlagDate
Santhosh.thottingalinspected12:34, 21 January 2012
Santhosh.thottingaltested12:34, 21 January 2012

Status & tagging log