r109649 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109648‎ | r109649 | r109650 >
Date:21:39, 20 January 2012
Author:rmoen
Status:ok
Tags:
Comment:
remove BeforePageDisplay hook, interfaceConcurrency module shoudld be loaded as needed. Not on every page.
Modified paths:
  • /trunk/extensions/InterfaceConcurrency/InterfaceConcurrency.hooks.php (modified) (history)
  • /trunk/extensions/InterfaceConcurrency/InterfaceConcurrency.php (modified) (history)

Diff [purge]

Index: trunk/extensions/InterfaceConcurrency/InterfaceConcurrency.php
@@ -50,7 +50,6 @@
5151
5252 // Hooks
5353 $wgAutoloadClasses['InterfaceConcurrencyHooks'] = $dir . 'InterfaceConcurrency.hooks.php';
54 -$wgHooks['BeforePageDisplay'][] = 'InterfaceConcurrencyHooks::beforePageDisplay';
5554 $wgHooks['LoadExtensionSchemaUpdates'][] = 'InterfaceConcurrencyHooks::onLoadExtensionSchemaUpdates';
5655
5756 // Resources
Index: trunk/extensions/InterfaceConcurrency/InterfaceConcurrency.hooks.php
@@ -2,22 +2,9 @@
33
44 class InterfaceConcurrencyHooks {
55 /**
6 - * Adds Interface Concurrency JS to the output
 6+ * Runs InterfaceConcurrency schema updates#
77 *
8 - * @param $output OutputPage
9 - * @param $skin Skin
10 - * @return bool
11 - */
12 - public static function beforePageDisplay( &$output, &$skin ) {
13 - $output->addModules( array( 'jquery.interfaceConcurrency' ) );
14 - return true;
15 - }
16 -
17 - /**
18 - * Runs InterfaceConcurrency schema updates
19 - *
208 * @param $updater DatabaseUpdater
21 - * @return bool
229 */
2310 public static function onLoadExtensionSchemaUpdates( $updater = null ) {
2411 $dir = dirname( __FILE__ ) . '/sql';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108868added js resources for checking in / out resources via concurrency api. load...rmoen22:48, 13 January 2012

Status & tagging log