r109630 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109629‎ | r109630 | r109631 >
Date:18:31, 20 January 2012
Author:gregchiasson
Status:ok
Tags:aft 
Comment:
AFT5 - HTML change for design of filter/sort optins on feedback page. Needs more JS/PHP changes, but the designers want to see the markup first, so here's that.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -22,9 +22,9 @@
2323 'comment'
2424 );
2525 private $sorts = array(
26 - 'newest',
27 - 'oldest',
28 - 'helpful'
 26+ 'age',
 27+ 'helpfulness',
 28+ 'rating'
2929 );
3030
3131 /**
@@ -135,7 +135,13 @@
136136
137137 $sortLabels = array();
138138 foreach ( $this->sorts as $sort ) {
139 - $sortLabels[] = Html::element(
 139+ $sortLabels[] = Html::element( 'span',
 140+ array(
 141+ 'id' => 'articleFeedbackv5-sort-arrow-' . $sort,
 142+ 'class' => 'articleFeedbackv5-sort-arrow'
 143+
 144+ ), '' )
 145+ . Html::element(
140146 'a',
141147 array(
142148 'href' => '#',
@@ -173,7 +179,7 @@
174180 . Html::closeElement( 'div' )
175181 . Html::openElement(
176182 'div',
177 - array( 'id' => 'articleFeedbackv5-sort' )
 183+ array( 'id' => 'articleFeedbackv5-filter' )
178184 )
179185 . $this->msg( 'articlefeedbackv5-special-filter-label-before' )->escaped()
180186 . $filterSelect->getHTML()

Status & tagging log