r109574 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109573‎ | r109574 | r109575 >
Date:22:04, 19 January 2012
Author:tstarling
Status:ok
Tags:
Comment:
* (bug 24357) Fix compile error with PHP 5.2.x
* Fix configure error when CXXFLAGS has a space in it, introduced in r74041. Don't bother saving CXXFLAGS if you're not going to restore it.
* Fixed spelling error in README
Modified paths:
  • /trunk/extensions/wikidiff2/README (modified) (history)
  • /trunk/extensions/wikidiff2/config.m4 (modified) (history)
  • /trunk/extensions/wikidiff2/php_wikidiff2.cpp (modified) (history)

Diff [purge]

Index: trunk/extensions/wikidiff2/config.m4
@@ -36,8 +36,6 @@
3737
3838 PHP_SUBST(WIKIDIFF2_SHARED_LIBADD)
3939 AC_DEFINE(HAVE_WIKIDIFF2, 1, [ ])
40 - export CXXFLAGS_SAVE=$CXXFLAGS
4140 export CXXFLAGS="-Wno-write-strings $CXXFLAGS"
4241 PHP_NEW_EXTENSION(wikidiff2, php_wikidiff2.cpp wikidiff2.cpp, $ext_shared)
43 - export CXXFLAGS="$CXXFLAGS"
4442 fi
Index: trunk/extensions/wikidiff2/php_wikidiff2.cpp
@@ -12,7 +12,7 @@
1313
1414 static int le_wikidiff2;
1515
16 -const zend_function_entry wikidiff2_functions[] = {
 16+zend_function_entry wikidiff2_functions[] = {
1717 PHP_FE(wikidiff2_do_diff, NULL)
1818 {NULL, NULL, NULL}
1919 };
@@ -91,7 +91,7 @@
9292 Wikidiff2::String text1String(text1, text1_len);
9393 Wikidiff2::String text2String(text2, text2_len);
9494 const Wikidiff2::String & ret = wikidiff2.execute(text1String, text2String, numContextLines);
95 - RETURN_STRINGL(ret.data(), ret.size(), 1);
 95+ RETURN_STRINGL( const_cast<char*>(ret.data()), ret.size(), 1);
9696 } catch (std::bad_alloc &e) {
9797 zend_error(E_WARNING, "Out of memory in wikidiff2_do_diff().");
9898 } catch (...) {
Index: trunk/extensions/wikidiff2/README
@@ -27,7 +27,7 @@
2828 * (bug 25697) Add &#160; to empty context lines
2929
3030 2010-09-30
31 -* Automaticly use CXXFLAGS=-Wno-write-strings
 31+* Automatically use CXXFLAGS=-Wno-write-strings
3232
3333 2010-06-14
3434 * Converted the extension from swig to PHP native.

Sign-offs

UserFlagDate
Platonidesinspected22:16, 19 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74041automaticly build with CXXFLAGS="-Wno-write-strings"hashar21:11, 30 September 2010

Status & tagging log