r109529 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r109528‎ \| r109529 \| r109530 >
Date:	12:52, 19 January 2012
Author:	siebrand
Status:	ok (Comments)
Tags:	backcompat, languagegetmagic
Comment:	Remove use of deprecated LanguageGetMagic hook. Remove a few globals or constants that were used for magic words. Trim trailing whitespace and update indentation in a few place.
Modified paths:	/trunk/extensions/ShoutBox/ShoutBox.i18n.magic.php (added) (history) /trunk/extensions/ShoutBox/ShoutBox.php (modified) (history) /trunk/extensions/SimpleSecurity/SimpleSecurity.i18n.magic.php (added) (history) /trunk/extensions/SimpleSecurity/SimpleSecurity.php (modified) (history) /trunk/extensions/SimpleSecurity/SimpleSecurity_body.php (modified) (history) /trunk/extensions/SmoothGallery/SmoothGallery.php (modified) (history) /trunk/extensions/SmoothGallery/SmoothGalleryParser.php (modified) (history) /trunk/extensions/StockCharts/StockCharts.i18n.magic.php (added) (history) /trunk/extensions/StockCharts/StockCharts.php (modified) (history) /trunk/extensions/SubPageList/SubPageCount.class.php (modified) (history) /trunk/extensions/SubPageList/SubPageList.class.php (modified) (history) /trunk/extensions/SubPageList/SubPageList.i18n.magic.php (modified) (history) /trunk/extensions/SubPageList/SubPageList.php (modified) (history) /trunk/extensions/ThumbParser/ThumbParser.i18n.magic.php (added) (history) /trunk/extensions/ThumbParser/ThumbParser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SubPageList/SubPageList.i18n.magic.php
—	—	@@ -16,6 +16,8 @@
17	17	$magicWords['en'] = array(
18	18	'splist' => array( 0, 'splist' ),
19	19	'subpages' => array( 0, 'subpages' ),
	20	+ 'subpagelist' => array( 0, 'subpagelist' ),
	21	+ 'subpagecount' => array( 0, 'subpagecount' ),
20	22	);
21	23
22	24	/** Arabic (العربية) */
Index: trunk/extensions/SubPageList/SubPageList.php
—	—	@@ -60,9 +60,7 @@
61	61	$wgAutoloadClasses['SPLHooks'] = $egSPLIP . '/SubPageList.hooks.php';
62	62
63	63	$wgHooks['ParserFirstCallInit'][] = 'SubPageList::staticInit';
64		~~-$wgHooks['LanguageGetMagic'][] = 'SubPageList::staticMagic';~~
65	64	$wgHooks['ParserFirstCallInit'][] = 'SubPageCount::staticInit';
66		~~-$wgHooks['LanguageGetMagic'][] = 'SubPageCount::staticMagic';~~
67	65
68	66	$wgHooks['ArticleInsertComplete'][] = 'SPLHooks::onArticleInsertComplete';
69	67	$wgHooks['ArticleDeleteComplete'][] = 'SPLHooks::onArticleDeleteComplete';
Index: trunk/extensions/SubPageList/SubPageCount.class.php
—	—	@@ -16,20 +16,10 @@
17	17	* @copyright © 2008 James McCormack, preceding version Martin Schallnahs, original Rob Church
18	18	*/
19	19	final class SubPageCount extends SubPageBase {
20		-
21	20	/**
22	21	* No LSB in pre-5.3 PHP sigh.
23	22	* This is to be refactored as soon as php >=5.3 becomes acceptable.
24	23	*/
25		~~- public static function staticMagic( array &$magicWords, $langCode ) {~~
26		~~- $instance = new self;~~
27		~~- return $instance->magic( $magicWords, $langCode );~~
28		~~- }~~
29		-
30		- /**
31		~~- * No LSB in pre-5.3 PHP sigh.~~
32		~~- * This is to be refactored as soon as php >=5.3 becomes acceptable.~~
33		~~- */~~
34	24	public static function staticInit( Parser &$wgParser ) {
35	25	$instance = new self;
36	26	return $instance->init( $wgParser );
Index: trunk/extensions/SubPageList/SubPageList.class.php
—	—	@@ -16,20 +16,9 @@
17	17	* @copyright © 2008 James McCormack, preceding version Martin Schallnahs, original Rob Church
18	18	*/
19	19	final class SubPageList extends SubPageBase {
20		-
21	20	/**
22	21	* No LST in pre-5.3 PHP sigh.
23	22	* This is to be refactored as soon as php >=5.3 becomes acceptable.
24		~~- */~~
25		~~- public static function staticMagic( array &$magicWords, $langCode ) {~~
26		~~- $className = __CLASS__;~~
27		~~- $instance = new $className();~~
28		~~- return $instance->magic( $magicWords, $langCode );~~
29		~~- }~~
30		-
31		- /**
32		~~- * No LST in pre-5.3 PHP sigh.~~
33		~~- * This is to be refactored as soon as php >=5.3 becomes acceptable.~~
34	23	*/
35	24	public static function staticInit( Parser &$wgParser ) {
36	25	$className = __CLASS__;
Index: trunk/extensions/StockCharts/StockCharts.i18n.magic.php
—	—	@@ -0,0 +1,10 @@
	2	+<?php
	3	+/**
	4	+ * Internationalization file for magic words.
	5	+ */
	6	+
	7	+$magicWords = array();
	8	+
	9	+$magicWords['en'] = array(
	10	+ 'stockchart' => array( 0, 'stockchart' ),
	11	+);
Property changes on: trunk/extensions/StockCharts/StockCharts.i18n.magic.php
___________________________________________________________________
Added: svn:eol-style
1	12	+ native
Added: svn:keywords
2	13	+ Id
Index: trunk/extensions/StockCharts/StockCharts.php
—	—	@@ -18,7 +18,6 @@
19	19	*/
20	20
21	21	$wgHooks['ParserFirstCallInit'][] = 'efStockChartsSetHooks';
22		~~-$wgHooks['LanguageGetMagic'][] = 'efStockChartsMagic';~~
23	22
24	23	$wgExtensionCredits['parserhook'][] = array(
25	24	'name' => 'StockCharts',
—	—	@@ -26,11 +25,12 @@
27	26	'author' => 'Brendan Meutzner, Anton Zolotkov, Roger Fong',
28	27	'descriptionmsg' => 'stockcharts-desc',
29	28	'url' => 'https://www.mediawiki.org/wiki/Extension:StockCharts',
30		~~- 'version' => '0.2',~~
	29	+ 'version' => '0.3',
31	30	);
32	31
33	32	# Internationalisation file
34	33	$wgExtensionMessagesFiles['StockCharts'] = dirname( __FILE__ ) . '/StockCharts.i18n.php';
	34	+$wgExtensionMessagesFiles['StockChartsMagic'] = dirname( __FILE__ ) . '/StockCharts.i18n.magic.php';
35	35
36	36	$wgAutoloadClasses['StockCharts'] = dirname( __FILE__ ) . '/StockCharts_body.php';
37	37
—	—	@@ -39,8 +39,3 @@
40	40	$parser->setFunctionHook( 'stockchart', array( 'StockCharts', 'renderParserFunction' ) ); // hook for {{#stockchart ..}}
41	41	return true;
42	42	}
43		-
44		~~-function efStockChartsMagic( &$magicWords, $langCode ) {~~
45		~~- $magicWords['stockchart'] = array( 0, 'stockchart' );~~
46		~~- return true;~~
47		-}
Index: trunk/extensions/SmoothGallery/SmoothGallery.php
—	—	@@ -35,7 +35,7 @@
36	36	$wgExtensionCredits['other'][] = array(
37	37	'path' => __FILE__,
38	38	'name' => 'SmoothGallery parser extension',
39		~~- 'version' => '1.1h',~~
	39	+ 'version' => '1.1i',
40	40	'author' => 'Ryan Lane',
41	41	'descriptionmsg' => 'smoothgallery-desc',
42	42	'url' => 'https://www.mediawiki.org/wiki/Extension:SmoothGallery',
—	—	@@ -47,11 +47,7 @@
48	48
49	49	$dir = dirname( __FILE__ ) . '/';
50	50	$wgExtensionMessagesFiles['SmoothGallery'] = $dir . 'SmoothGallery.i18n.php';
51		~~-if( version_compare( $wgVersion, '1.16alpha', '>=' ) ) {~~
52		~~- $wgExtensionMessagesFiles['SmoothGalleryMagic'] = $dir . 'SmoothGallery.i18n.magic.php';~~
53		~~-} else {~~
54		~~- $wgHooks['LanguageGetMagic'][] = 'smoothGalleryLanguageGetMagic';~~
55		-}
	51	+$wgExtensionMessagesFiles['SmoothGalleryMagic'] = $dir . 'SmoothGallery.i18n.magic.php';
56	52	$wgAutoloadClasses['SmoothGallery'] = $dir . 'SmoothGalleryClass.php';
57	53	$wgAutoloadClasses['SmoothGalleryParser'] = $dir . 'SmoothGalleryParser.php';
58	54
—	—	@@ -150,12 +146,3 @@
151	147	}
152	148	return true;
153	149	}
154		-
155		-/**
156		~~- * We ignore langCode - parser function names can be translated but~~
157		~~- * we are not using this feature~~
158		~~- */~~
159		~~-function smoothGalleryLanguageGetMagic( $magicWords, $langCode ) {~~
160		~~- $magicWords['sgallery'] = array( 0, 'sgallery' );~~
161		~~- return true;~~
162		-}
Index: trunk/extensions/SmoothGallery/SmoothGalleryParser.php
—	—	@@ -1,7 +1,6 @@
2	2	<?php
3	3
4	4	class SmoothGalleryParser {
5		-
6	5	var $set;
7	6	var $argumentArray;
8	7	var $galleriesArray;
—	—	@@ -287,5 +286,4 @@
288	287
289	288	return $images;
290	289	}
291		-
292	290	}
Index: trunk/extensions/SimpleSecurity/SimpleSecurity.i18n.magic.php
—	—	@@ -0,0 +1,11 @@
	2	+<?php
	3	+/**
	4	+ * Internationalization file for magic words.
	5	+ */
	6	+
	7	+$magicWords = array();
	8	+
	9	+$magicWords['en'] = array(
	10	+ 'ifgroup' => array( 0, 'ifgroup' ),
	11	+ 'ifusercan' => array( 0, 'ifusercan' ),
	12	+);
Property changes on: trunk/extensions/SimpleSecurity/SimpleSecurity.i18n.magic.php
___________________________________________________________________
Added: svn:eol-style
1	13	+ native
Added: svn:keywords
2	14	+ Id
Index: trunk/extensions/SimpleSecurity/SimpleSecurity_body.php
—	—	@@ -22,15 +22,15 @@
23	23
24	24	function setup() {
25	25	global $wgParser, $wgHooks, $wgLogTypes, $wgLogNames, $wgLogHeaders, $wgLogActions,
26		~~- $wgSecurityMagicIf, $wgSecurityMagicGroup, $wgSecurityExtraActions, $wgSecurityExtraGroups,~~
	26	+ $wgSecurityExtraActions, $wgSecurityExtraGroups,
27	27	$wgRestrictionTypes, $wgRestrictionLevels, $wgGroupPermissions,
28	28	$wgSecurityRenderInfo, $wgSecurityAllowUnreadableLinks, $wgSecurityGroupsArticle;
29	29
30	30	# Add our hooks
31	31	$wgHooks['UserGetRights'][] = $this;
32	32	$wgHooks['ImgAuthBeforeStream'][] = $this;
33		~~- if ( $wgSecurityMagicIf ) $wgParser->setFunctionHook( $wgSecurityMagicIf, array( $this, 'ifUserCan' ) );~~
34		~~- if ( $wgSecurityMagicGroup ) $wgParser->setFunctionHook( $wgSecurityMagicGroup, array( $this, 'ifGroup' ) );~~
	33	+ $wgParser->setFunctionHook( 'ifusercan', array( $this, 'ifUserCan' ) );
	34	+ $wgParser->setFunctionHook( 'ifgroup', array( $this, 'ifGroup' ) );
35	35	if ( $wgSecurityRenderInfo ) $wgHooks['OutputPageBeforeHTML'][] = $this;
36	36	if ( $wgSecurityAllowUnreadableLinks ) $wgHooks['BeforePageDisplay'][] = $this;
37	37
—	—	@@ -72,7 +72,6 @@
73	73
74	74	}
75	75
76		-
77	76	/**
78	77	* Process the ifUserCan conditional security directive
79	78	*/
—	—	@@ -80,7 +79,6 @@
81	80	return Title::newFromText( $pagename )->userCan( $action ) ? $then : $else;
82	81	}
83	82
84		-
85	83	/**
86	84	* Process the ifGroup conditional security directive
87	85	* - evaluates to true if current uset belongs to any of the comma-separated users and/or groups in the first parameter
—	—	@@ -91,7 +89,6 @@
92	90	return count( $intersection ) > 0 ? $then : $else;
93	91	}
94	92
95		-
96	93	/**
97	94	* Convert the urls with guids for hrefs into non-clickable text of class "unreadable"
98	95	*/
—	—	@@ -104,7 +101,6 @@
105	102	return true;
106	103	}
107	104
108		-
109	105	/**
110	106	* Render security info if any restrictions on this title
111	107	* Also make restricted pages not archive by robots
—	—	@@ -462,5 +458,4 @@
463	459	}
464	460	return $db;
465	461	}
466		-
467	462	}
Index: trunk/extensions/SimpleSecurity/SimpleSecurity.php
—	—	@@ -22,17 +22,15 @@
23	23	* @copyright © 2007-2011 Aran Dunkley
24	24	* @license GNU General Public Licence 2.0 or later
25	25	*/
26		~~-define( 'SIMPLESECURITY_VERSION', '5.0.4, 2011-06-29' );~~
	26	+define( 'SIMPLESECURITY_VERSION', '5.1.0, 2012-01-19' );
27	27
28	28	# Load the SimpleSecurity class and messages
29	29	$dir = dirname( __FILE__ ) . '/';
30	30	$wgExtensionMessagesFiles['SimpleSecurity'] = $dir . 'SimpleSecurity.i18n.php';
	31	+$wgExtensionMessagesFiles['SimpleSecurityMagic'] = $dir . 'SimpleSecurity.i18n.magic.php';
31	32	$wgAutoloadClasses['SimpleSecurity'] = $dir . 'SimpleSecurity_body.php';
32	33
33	34	# Global security settings
34		~~-# TODO: Localize magic words~~
35		~~-$wgSecurityMagicIf = "ifusercan"; # the name for doing a permission-based conditional~~
36		~~-$wgSecurityMagicGroup = "ifgroup"; # the name for doing a group-based conditional~~
37	35	$wgSecurityLogActions = array( 'edit', 'download' ); # Actions that should be logged
38	36	$wgSecurityAllowUser = false; # Allow restrictions based on user not just group
39	37	$wgSecurityAllowUnreadableLinks = false; # Should links to unreadable pages be allowed? (MW1.7+)
—	—	@@ -58,7 +56,6 @@
59	57	# Don't use the DB hook by default since it's voodoo
60	58	if( !isset( $wgSecurityUseDBHook ) ) $wgSecurityUseDBHook = false;
61	59
62		~~-$wgHooks['LanguageGetMagic'][] = 'wfSimpleSecurityLanguageGetMagic';~~
63	60	$wgExtensionCredits['parserhook'][] = array(
64	61	'path' => __FILE__,
65	62	'name' => "SimpleSecurity",
—	—	@@ -75,16 +72,6 @@
76	73	# If using the DBHook, apply it now (must be done from the root scope since it creates classes)
77	74	if( $wgSecurityUseDBHook ) SimpleSecurity::applyDatabaseHook();
78	75
79		-/**
80		~~- * Register magic words~~
81		~~- */~~
82		~~-function wfSimpleSecurityLanguageGetMagic( &$magicWords, $langCode = 0 ) {~~
83		~~- global $wgSecurityMagicIf, $wgSecurityMagicGroup;~~
84		~~- $magicWords[$wgSecurityMagicIf] = array( $langCode, $wgSecurityMagicIf );~~
85		~~- $magicWords[$wgSecurityMagicGroup] = array( $langCode, $wgSecurityMagicGroup );~~
86		~~- return true;~~
87		-}
88		-
89	76	function wfSimpleSecurityMessagesPreLoad( $title, &$text ) {
90	77	global $wgSecurityExtraActions, $wgSecurityExtraGroups;
91	78
Index: trunk/extensions/ThumbParser/ThumbParser.i18n.magic.php
—	—	@@ -0,0 +1,10 @@
	2	+<?php
	3	+/**
	4	+ * Internationalization file for magic words.
	5	+ */
	6	+
	7	+$magicWords = array();
	8	+
	9	+$magicWords['en'] = array(
	10	+ 'thumb' => array( 0, 'thumb' ),
	11	+);
Property changes on: trunk/extensions/ThumbParser/ThumbParser.i18n.magic.php
___________________________________________________________________
Added: svn:eol-style
1	12	+ native
Added: svn:keywords
2	13	+ Id
Index: trunk/extensions/ThumbParser/ThumbParser.php
—	—	@@ -1,6 +1,6 @@
2	2	<?php
3		-/**
4		~~-* @addtogroup Extensions~~
	3	+/**
	4	+* @addtogroup Extensions
5	5	*/
6	6	// Check environment
7	7	if ( !defined( 'MEDIAWIKI' ) ) {
—	—	@@ -18,55 +18,45 @@
19	19	'description'=>'Prints users Thumb size',
20	20	'descriptionmsg' => 'thumbparser-desc',
21	21	'author'=>'[http://www.dasch-tour.de DaSch]',
22		~~- 'version'=>'0.1',~~
	22	+ 'version'=>'0.2',
23	23	);
24	24	$dir = dirname( __FILE__ ) . '/';
25	25
26	26	// Internationalization
27	27	$wgExtensionMessagesFiles['ThumbParser'] = $dir . 'ThumbParser.i18n.php';
	28	+$wgExtensionMessagesFiles['ThumbParserMagic'] = $dir . 'ThumbParser.i18n.magic.php';
28	29
29	30	# Define a setup function
30	31	$wgHooks['ParserFirstCallInit'][] = 'efThumbParserFunction_Setup';
31		~~-# Add a hook to initialise the magic word~~
32		~~-$wgHooks['LanguageGetMagic'][] = 'efThumbParserFunction_Magic';~~
33		-
	32	+
34	33	function efThumbParserFunction_Setup( $parser ) {
35	34	# Set a function hook associating the "example" magic word with our function
36	35	$parser->setFunctionHook( 'thumb', 'efThumbParserFunction_Render' );
37	36	return true;
38	37	}
39		-
40		~~-function efThumbParserFunction_Magic( &$magicWords, $langCode ) {~~
41		~~- # Add the magic word~~
42		~~- # The first array element is case sensitive, in this case it is not case sensitive~~
43		~~- # All remaining elements are synonyms for our parser function~~
44		~~- $magicWords['thumb'] = array( 0, 'thumb' );~~
45		~~- # unless we return true, other parser functions extensions won't get loaded.~~
46		~~- return true;~~
47		-}
48		-
	38	+
49	39	function efThumbParserFunction_Render( $parser, $param1 = '') {
50		~~- # The parser function itself~~
51		~~- # The input parameters are wikitext with templates expanded~~
52		~~- # The output should be wikitext too~~
53		~~- global $wgThumbLimits, $wgUser;~~
54		~~- $param1 = strtolower($param1);~~
55		~~- $parser->disableCache(); # Mark this content as uncacheable~~
56		~~- $wopt = $wgUser->getOption('thumbsize');~~
57		~~- switch ($param1) {~~
58		~~- case 'size':~~
59		~~- $output = $wgThumbLimits[$wopt];~~
60		~~- break;~~
61		~~- case 'px':~~
62		~~- $output = $wgThumbLimits[$wopt].'px';~~
63		~~- break;~~
64		~~- case 'width':~~
65		~~- $size = intval($wgThumbLimits[$wopt])+10;~~
66		~~- $strsize = strval($size);~~
67		~~- $output = $strsize."px";~~
68		~~- break;~~
69		~~- default:~~
70		~~- $output = $wgThumbLimits[$wopt];~~
71		~~- }~~
72		~~- return $output;~~
73		-}
\ No newline at end of file
	40	+ # The parser function itself
	41	+ # The input parameters are wikitext with templates expanded
	42	+ # The output should be wikitext too
	43	+ global $wgThumbLimits, $wgUser;
	44	+ $param1 = strtolower($param1);
	45	+ $parser->disableCache(); # Mark this content as uncacheable
	46	+ $wopt = $wgUser->getOption('thumbsize');
	47	+ switch ($param1) {
	48	+ case 'size':
	49	+ $output = $wgThumbLimits[$wopt];
	50	+ break;
	51	+ case 'px':
	52	+ $output = $wgThumbLimits[$wopt].'px';
	53	+ break;
	54	+ case 'width':
	55	+ $size = intval($wgThumbLimits[$wopt])+10;
	56	+ $strsize = strval($size);
	57	+ $output = $strsize."px";
	58	+ break;
	59	+ default:
	60	+ $output = $wgThumbLimits[$wopt];
	61	+ }
	62	+ return $output;
	63	+}
Index: trunk/extensions/ShoutBox/ShoutBox.php
—	—	@@ -57,7 +57,7 @@
58	58	$wgExtensionCredits['parserhook'][] = array(
59	59	'path' => __FILE__,
60	60	'name' => 'ShoutBox',
61		~~- 'version' => '0.2.2',~~
	61	+ 'version' => '0.3.0',
62	62	'author' => array( 'Jim R. Wilson', 'Jack Phoenix' ),
63	63	'url' => 'https://www.mediawiki.org/wiki/Extension:ShoutBox',
64	64	'descriptionmsg' => 'shoutbox-desc',
—	—	@@ -79,17 +79,18 @@
80	80	// Internationalization file
81	81	$dir = dirname( __FILE__ ) . '/';
82	82	$wgExtensionMessagesFiles['ShoutBox'] = $dir . 'ShoutBox.i18n.php';
	83	+$wgExtensionMessagesFiles['ShoutBoxMagic'] = $dir . 'ShoutBox.i18n.magic.php';
83	84
84	85	// Hooked functions
85	86	$wgHooks['ParserFirstCallInit'][] = 'ShoutBox::setup';
86		~~-$wgHooks['LanguageGetMagic'][] = 'ShoutBox::parserFunctionMagic';~~
87	87	$wgHooks['ParserBeforeTidy'][] = 'ShoutBox::placeholderCorrections';
88	88
	89	+// @todo FIXME: Move classes out of the init file.
	90	+
89	91	/**
90	92	* Wrapper class for encapsulating ShoutBox related parser methods
91	93	*/
92	94	class ShoutBox {
93		-
94	95	/**
95	96	* Sets up parser functions.
96	97	*
—	—	@@ -103,18 +104,6 @@
104	105	}
105	106
106	107	/**
107		~~- * Adds magic words for parser functions.~~
108		- *
109		~~- * @param $magicWords Array: available magic words~~
110		~~- * @param $langCode String: language code~~
111		~~- * @return Boolean: always true~~
112		~~- */~~
113		~~- public static function parserFunctionMagic( &$magicWords, $langCode = 'en' ) {~~
114		~~- $magicWords['shoutbox'] = array( 0, 'shoutbox' );~~
115		~~- return true;~~
116		~~- }~~
117		-
118		- /**
119	108	* Embeds ShoutBox
120	109	*
121	110	* @param $parser Object: Instance of running Parser.
Index: trunk/extensions/ShoutBox/ShoutBox.i18n.magic.php
—	—	@@ -0,0 +1,10 @@
	2	+<?php
	3	+/**
	4	+ * Internationalization file for magic words.
	5	+ */
	6	+
	7	+$magicWords = array();
	8	+
	9	+$magicWords['en'] = array(
	10	+ 'shoutbox' => array( 0, 'shoutbox' ),
	11	+);
Property changes on: trunk/extensions/ShoutBox/ShoutBox.i18n.magic.php
___________________________________________________________________
Added: svn:eol-style
1	12	+ native
Added: svn:keywords
2	13	+ Id

Comments

#Comment by Bsitu (talk | contribs) 20:05, 19 January 2012

$wgExtensionMessagesFiles['StockCharts'] =  dirname( __FILE__ ) . '/StockCharts.i18n.php';
$wgExtensionMessagesFiles['StockChartsMagic'] =  dirname( __FILE__ ) . '/StockCharts.i18n.magic.php';

$wgAutoloadClasses['StockCharts'] = dirname( __FILE__ ) . '/StockCharts_body.php';

dirname( __FILE__ ) should be assigned to variable and use the variable instead of multiple call to this function

Status & tagging log

19:17, 11 February 2012 RobLa-WMF (talk | contribs) changed the tags for r109529 [added: backcompat]
22:03, 20 January 2012 Aaron Schulz (talk | contribs) changed the status of r109529 [removed: new added: ok]
14:11, 19 January 2012 Siebrand (talk | contribs) changed the tags for r109529 [added: languagegetmagic]