r109511 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109510‎ | r109511 | r109512 >
Date:10:05, 19 January 2012
Author:ialex
Status:ok
Tags:
Comment:
$wgLanguageCode goes with $wgContLang, not $wgLang. This was breaking ApiBlockTest because $wgContLang->getCode() != $wgLanguageCode.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/XmlTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/XmlTest.php
@@ -4,17 +4,15 @@
55 private static $oldLang;
66
77 public function setUp() {
8 - global $wgLang, $wgLanguageCode;
 8+ global $wgLang;
99
1010 self::$oldLang = $wgLang;
11 - $wgLanguageCode = 'en';
12 - $wgLang = Language::factory( $wgLanguageCode );
 11+ $wgLang = Language::factory( 'en' );
1312 }
1413
1514 public function tearDown() {
16 - global $wgLang, $wgLanguageCode;
 15+ global $wgLang;
1716 $wgLang = self::$oldLang;
18 - $wgLanguageCode = $wgLang->getCode();
1917 }
2018
2119 public function testExpandAttributes() {

Status & tagging log