r109489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109488‎ | r109489 | r109490 >
Date:04:16, 19 January 2012
Author:awjrichards
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/CongressLookup (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CongressLookup/CongressLookup.i18n.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/CongressLookup/SpecialCongressLookup.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/CongressLookup/CongressLookup.i18n.php
@@ -20,7 +20,8 @@
2121 'congresslookup-fax' => 'Fax: $1',
2222 'congresslookup-contact-form' => 'Contact form',
2323 'congresslookup-twitter' => 'Twitter: $1',
24 - 'congresslookup-your-reps' => 'Your Representatives:',
 24+ 'congresslookup-your-reps' => 'Your representatives:',
 25+ 'congresslookup-contact-your-reps' => 'Contact your representatives:',
2526 'congresslookup-no-house-rep' => 'No House representative was found for your zip code.',
2627 'congresslookup-no-senators' => 'No senators were found for your zip code.',
2728 'congresslookup-report-errors' => 'Report an error',
Index: branches/wmf/1.18wmf1/extensions/CongressLookup/SpecialCongressLookup.php
@@ -99,7 +99,7 @@
100100
101101 $congressTable = '';
102102
103 - $congressTable .= Html::element( 'h4', array(), 'Your Representatives:' );
 103+ $congressTable .= Html::element( 'h4', array(), wfMsg( 'congresslookup-your-reps' ) );
104104
105105 if ( $myRepresentatives ) {
106106 foreach ( $myRepresentatives as $myRepresentative ) {
@@ -207,8 +207,8 @@
208208 private function getZipForm( $isError=false ) {
209209 $htmlOut = <<<HTML
210210 <div id="sopaZipForm" class="sopaActionDiv">
211 -<h4>Contact your representatives</h4>
212211 HTML;
 212+ $htmlOut .= Html::element( 'h4', array(), wfMsg( 'congresslookup-contact-your-reps' ));
213213 if ( $isError ) {
214214 $htmlOut .= Html::element( 'p', array( 'class' => 'error' ), wfMsg( 'congresslookup-zipcode-error' ));
215215 }
@@ -388,11 +388,16 @@
389389 }
390390 div#instructions {
391391 position: absolute;
392 - top: 67px;
393 - left: 480px;
 392+ top: 47px;
 393+ left: 460px;
394394 text-align: left;
395395 width: 500px;
396 - padding-bottom: 30px;
 396+ padding: 20px;
 397+ background-color: #ffffff;
 398+ filter:alpha(opacity=90);
 399+ -moz-opacity:0.90;
 400+ -khtml-opacity: 0.90;
 401+ opacity: 0.90;
397402 }
398403 div#instructions p {
399404 text-align:justify;
@@ -416,6 +421,12 @@
417422 div#contacts form {
418423 margin-bottom: 1em;
419424 }
 425+div#contacts a:link, div#contacts a:visited {
 426+ color: #dedede;
 427+}
 428+div#contacts a:hover, div#contacts a:active {
 429+ color: #ffffff;
 430+}
420431 table.person {
421432 margin-bottom: 1em;
422433 margin-left: 20px;
@@ -503,11 +514,11 @@
504515 }
505516 div#instructions {
506517 position: absolute;
507 - top: 67px;
508 - left: 480px;
 518+ top: 47px;
 519+ left: 460px;
509520 text-align: left;
510521 width: 500px;
511 - padding-bottom: 30px;
 522+ padding: 20px;
512523 }
513524 div#instructions p {
514525 text-align:justify;
Property changes on: branches/wmf/1.18wmf1/extensions/CongressLookup/SpecialCongressLookup.php
___________________________________________________________________
Modified: svn:mergeinfo
515526 Merged /trunk/extensions/CongressLookup/SpecialCongressLookup.php:r109485-109488
Property changes on: branches/wmf/1.18wmf1/extensions/CongressLookup
___________________________________________________________________
Modified: svn:mergeinfo
516527 Merged /trunk/extensions/CongressLookup:r109485-109488

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109485make top text editablekaldari03:54, 19 January 2012
r109486make more text editablekaldari03:59, 19 January 2012
r109487Styling changes for black on white including adding a translucent-ish box aro...awjrichards04:05, 19 January 2012
r109488formatting fixeskaldari04:11, 19 January 2012

Status & tagging log