r109435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109434‎ | r109435 | r109436 >
Date:21:24, 18 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/maintenance/cleanupUploadStash.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/maintenance/cleanupUploadStash.php
@@ -65,8 +65,13 @@
6666 $stash = new UploadStash( $repo );
6767
6868 foreach( $keys as $key ) {
69 - $stash->getFile( $key, true );
70 - $stash->removeFileNoAuth( $key );
 69+ try {
 70+ $stash->getFile( $key, true );
 71+ $stash->removeFileNoAuth( $key );
 72+ } catch ( UploadStashBadPathException $ex ) {
 73+ $this->output( 'Failed removing stashed upload with key:' . $key );
 74+ continue;
 75+ }
7176 }
7277 }
7378 }
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
7479 Merged /trunk/phase3:r109433

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109433Just experienced with commons. Dealt with UploadStashBadPathException...reedy21:20, 18 January 2012

Status & tagging log