r109430 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109429‎ | r109430 | r109431 >
Date:20:37, 18 January 2012
Author:amire80
Status:ok
Tags:
Comment:
Reset font-family of <textarea> explicitly, too. (Found thanks to auto-testing.)
Modified paths:
  • /trunk/extensions/WebFonts/resources/ext.webfonts.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WebFonts/resources/ext.webfonts.js
@@ -38,7 +38,7 @@
3939 }
4040
4141 // Set the web font and the fallback fonts.
42 - // Need to change the fonts of Input Select and Textarea explicitly.
 42+ // font-family of <input>, <select> and <textarea> must be changed explicitly.
4343 $( 'body, input, select, textarea' ).css(
4444 'font-family', '"' + font + '", Helvetica, Arial, sans-serif'
4545 );
@@ -66,8 +66,8 @@
6767 fontSize: mw.webfonts.oldconfig.fontSize
6868 });
6969
70 - // We need to reset the font family of Input and Select explicitly.
71 - $( 'input, select' ).css( 'font-family', mw.webfonts.oldconfig.fontFamily );
 70+ // font-family of <input>, <select> and <textarea> must be reset explicitly.
 71+ $( 'input, select, textarea' ).css( 'font-family', mw.webfonts.oldconfig.fontFamily );
7272
7373 // Reset the fonts applied for tags with lang attribute.
7474 $( '.webfonts-lang-attr' ).css( 'font-family', '' ).removeClass( 'webfonts-lang-attr' );

Status & tagging log