r109396 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r109395‎ \| r109396 \| r109397 >
Date:	16:57, 18 January 2012
Author:	gregchiasson
Status:	ok
Tags:	aft
Comment:	AFT5 - add IDs to elements in the feedback tools area of feedback page, for JS to hook into.
Modified paths:	/trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
—	—	@@ -247,9 +247,16 @@
248	248	# . Html::closeElement( 'div' );
249	249
250	250
251		~~- $tools = Html::openElement( 'div', array( 'class' => 'articleFeedbackv5-feedback-tools' ) )~~
252		~~- . Html::element( 'h3', array(), wfMessage( 'articlefeedbackv5-form-tools-label' )->text() )~~
253		~~- . Html::openElement( 'ul' )~~
	251	+ $tools = Html::openElement( 'div', array(
	252	+ 'class' => 'articleFeedbackv5-feedback-tools',
	253	+ 'id' => 'articleFeedbackv5-feedback-tools-'.$id
	254	+ ) )
	255	+ . Html::element( 'h3', array(
	256	+ 'id' => 'articleFeedbackv5-feedback-tools-header-'.$id
	257	+ ), wfMessage( 'articlefeedbackv5-form-tools-label' )->text() )
	258	+ . Html::openElement( 'ul', array(
	259	+ 'id' => 'articleFeedbackv5-feedback-tools-list-'.$id
	260	+ ) )
254	261	. ( $can_hide ? Html::rawElement( 'li', array(), Html::element( 'a', array(
255	262	'id' => "articleFeedbackv5-hide-link-$id",
256	263	'class' => 'articleFeedbackv5-hide-link'

01:55, 26 January 2012 Catrope (talk | contribs) changed the status of r109396 [removed: new added: ok]
14:30, 19 January 2012 Siebrand (talk | contribs) changed the tags for r109396 [added: aft]