r109363 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109362‎ | r109363 | r109364 >
Date:13:56, 18 January 2012
Author:yaron
Status:ok
Tags:
Comment:
Follow-up to r109076 - replaced openElement() and closeElement() with rawElement() - cleaner code, and works with MW 1.16
Modified paths:
  • /trunk/extensions/SemanticForms/includes/forminputs/SF_RadioButtonInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/forminputs/SF_RadioButtonInput.php
@@ -85,16 +85,14 @@
8686 array_key_exists( 'value_labels', $other_args ) &&
8787 is_array( $other_args['value_labels'] ) &&
8888 array_key_exists( $possible_value, $other_args['value_labels'] )
89 - )
90 - {
 89+ ) {
9190 $label = htmlspecialchars( $other_args['value_labels'][$possible_value] );
9291 } else {
9392 $label = $possible_value;
9493 }
9594
96 - $text .= "\t" . Html::openElement( 'span', $itemAttrs ) .
97 - Html::input( $input_name, $possible_value, 'radio', $radiobutton_attrs ) . " $label\n" .
98 - Html::closeElement( 'span' );
 95+ $text .= "\t" . Html::rawElement( 'span', $itemAttrs,
 96+ Html::input( $input_name, $possible_value, 'radio', $radiobutton_attrs ) . " $label" ) . "\n";
9997 }
10098
10199 $spanClass = 'radioButtonSpan';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109076Overhaul of HTML: replaced most calls to methods in Xml class with calls to H...yaron23:12, 16 January 2012

Status & tagging log