r109354 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109353‎ | r109354 | r109355 >
Date:10:36, 18 January 2012
Author:hashar
Status:ok
Tags:
Comment:
dbg toolbar: prevents screen jumping

preventDefault() ask the browser to ignore URL fragment which
we handle manually (by closing/opening tabs).

Works with Hovzer plugin added by r107982
ping r105122
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.debug.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.debug.js
——@@ -63,6 +63,9 @@
6464 }
6565 }
6666
 67+ // Skip hash fragment handling. Prevents screen from jumping.
 68+ e.preventDefault();
 69+
6770 $( this ).addClass( 'current ');
6871 $( '.mw-debug-panelink' ).not( this ).removeClass( 'current ');
6972

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r105122Adding new debugging toolbar...johnduhart18:29, 4 December 2011
r107982[jquery.footHovzer] new plugin for mw-log-console and mw-debug-toolbar...krinkle01:28, 4 January 2012

Status & tagging log