r109271 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109270‎ | r109271 | r109272 >
Date:00:54, 18 January 2012
Author:gregchiasson
Status:resolved (Comments)
Tags:aft 
Comment:
AFT5 - this is highly suboptimal, but it just needs to look OK for us to demo tomorrow, then I can go back and do it right.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -60,7 +60,7 @@
6161 'articlefeedbackv5-special-filter-label-before' => 'Show only:',
6262 'articlefeedbackv5-special-filter-label-after' => '',
6363 'articlefeedbackv5-special-showing' => '$1 feedback posts on this page', // FIXME: Needs plural support on $1.
64 - 'articleFeedbackv5-link' => 'Permanent link',
 64+ 'articleFeedbackv5-link' => 'Permalink',
6565 'articleFeedbackv5-updates-since' => '$1 Edits since post',
6666 'articlefeedbackv5-special-more' => 'More',
6767 'articlefeedbackv5-special-pagetitle' => 'Feedback: $1',
@@ -93,7 +93,7 @@
9494 'articlefeedbackv5-discussion-page' => 'Discussion',
9595 'articlefeedbackv5-whats-this' => 'Help',
9696 'articlefeedbackv5-invalid-page-id' => 'Invalid page ID',
97 - 'articlefeedbackv5-percent-found' => '$1% of users found what they were looking for.',
 97+ 'articlefeedbackv5-percent-found' => '% of users found what they were looking for.', // TODO: yeah, i know this is awful.
9898 'articlefeedbackv5-overall-rating' => 'Rating: $1/5',
9999 'articlefeedbackv5-special-title' => '==Feedback==',
100100 'articlefeedbackv5' => 'Article feedback dashboard',
Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -98,11 +98,11 @@
9999 'div',
100100 array( 'id' => 'articleFeedbackv5-percent-found-wrap' )
101101 )
102 - . Html::openElement(
103 - 'spam',
 102+ . Html::element(
 103+ 'span',
104104 array( 'class' => 'stat-marker positive' )
105 - )
106 - . $this->msg( 'articlefeedbackv5-percent-found', $found )->escaped()
 105+ , $found )
 106+ . wfMessage( 'articlefeedbackv5-percent-found' )
107107 . Html::closeElement( 'span' )
108108 . Html::closeElement( 'div' )
109109 . Html::element(

Follow-up revisions

RevisionCommit summaryAuthorDate
r109343Fix r109271/r109272 in a better way to make translations less awful.raymond08:14, 18 January 2012

Comments

#Comment by Catrope (talk | contribs)   01:43, 26 January 2012
+				. wfMessage( 'articlefeedbackv5-percent-found' )

You have to call ->escaped() here. Fixed in r109343.

Status & tagging log