r109218 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109217‎ | r109218 | r109219 >
Date:21:33, 17 January 2012
Author:hashar
Status:ok
Tags:
Comment:
remove cell{spacing,padding} from tables

Those are obsoletes, use CSS instead (although I did not apply padding).
Final step to pass w3c validation tests.
Modified paths:
  • /trunk/extensions/CongressLookup/SpecialCongressLookup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CongressLookup/SpecialCongressLookup.php
@@ -89,6 +89,7 @@
9090 table.person {
9191 margin-bottom: 1em;
9292 border: none;
 93+ border-collapse:collapse;
9394 }
9495 table.person td.name {
9596 font-weight: bold;
@@ -169,7 +170,7 @@
170171 if ( $myRepresentative ) {
171172
172173 $congressTable .= "\n" . Html::openElement( 'table', array (
173 - 'class' => 'person', 'cellpadding' => 0, 'cellspacing' => 0, 'border' => 0
 174+ 'class' => 'person',
174175 ) );
175176
176177 $congressTable .= "\n" . Html::rawElement( 'tr', array(),
@@ -201,7 +202,7 @@
202203 }
203204 foreach ( $mySenators as $senator ) {
204205 $congressTable .= "\n" . Html::openElement( 'table', array (
205 - 'class' => 'person', 'cellpadding' => 0, 'cellspacing' => 0, 'border' => 0
 206+ 'class' => 'person',
206207 ) );
207208
208209 $congressTable .= "\n" . Html::rawElement( 'tr', array(),

Status & tagging log