r109166 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r109165
|
r109166
|
r109167
>
Date:
17:39, 17 January 2012
Author:
krinkle
Status:
ok
Tags:
Comment:
[jquery.footHovzer] Remove buggy scrollstate preserver
* Intended to preserver scroll-state (which is shifted when an element to the bottom gains height). However too unstable to be more handy that it is annoying when it is not.
* Follows-up
r107982
Modified paths:
/trunk/phase3/resources/jquery/jquery.footHovzer.js
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/resources/jquery/jquery.footHovzer.js
—
—
@@ -22,7 +22,7 @@
23
23
24
24
footHovzer = {
25
25
update: function () {
26
- var $body, winTop;
26
+ var $body;
27
27
28
28
$body = $( 'body' );
29
29
if ( prevHeight === undefined ) {
—
—
@@ -31,12 +31,7 @@
32
32
} else {
33
33
newHeight = getHovzer().outerHeight( true );
34
34
$body.css( 'paddingBottom', ( parseFloat( $body.css( 'paddingBottom' ) ) - prevHeight ) + newHeight );
35
- // Update scroll so that page stays focusses on same area
36
- winTop = $(window).scrollTop();
37
- if ( $(document).height() - $(window).height() > winTop ) {
38
- $(window).scrollTop( winTop + ( newHeight - prevHeight ) );
39
- }
40
-
35
+
41
36
prevHeight = newHeight;
42
37
}
43
38
}
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r107982
[jquery.footHovzer] new plugin for mw-log-console and mw-debug-toolbar...
krinkle
01:28, 4 January 2012
Status & tagging log
20:43, 17 January 2012
Nikerabbit
(
talk
|
contribs
)
changed the
status
of r109166
[
removed:
new
added:
ok]