r109071 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109070‎ | r109071 | r109072 >
Date:22:54, 16 January 2012
Author:aaron
Status:ok
Tags:filebackend 
Comment:
Follow-up r108185: removed now unused ALLOW_STALE param
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -18,7 +18,6 @@
1919 const OVERWRITE = 2;
2020 const OVERWRITE_SAME = 4;
2121 const SKIP_LOCKING = 8;
22 - const ALLOW_STALE = 16;
2322
2423 /** @var FileBackendBase */
2524 protected $backend;
@@ -617,7 +616,6 @@
618617 * self::OVERWRITE_SAME Overwrite the file if the destination exists and has the
619618 * same contents as the source
620619 * self::SKIP_LOCKING Skip any file locking when doing the store
621 - * self::ALLOW_STALE Don't require latest data for existence checks
622620 * @return FileRepoStatus
623621 */
624622 public function store( $srcPath, $dstZone, $dstRel, $flags = 0 ) {
@@ -699,9 +697,6 @@
700698 if ( $flags & self::SKIP_LOCKING ) {
701699 $opts['nonLocking'] = true;
702700 }
703 - if ( $flags & self::ALLOW_STALE ) {
704 - $opts['allowStale'] = true;
705 - }
706701 $status->merge( $backend->doOperations( $operations, $opts ) );
707702 // Cleanup for disk source files...
708703 foreach ( $sourceFSFilesToDelete as $file ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108185Partially reverted r108111: we can't assume subclasses put thumbnails in the....aaron23:35, 5 January 2012

Status & tagging log