r108971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108970‎ | r108971 | r108972 >
Date:12:55, 15 January 2012
Author:mkroetzsch
Status:deferred
Tags:
Comment:
fixed problem with concept pages not listing pages properly (reason was confusion between '' and null for unset query bounds; using '' now throughout)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_ConceptPage.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_OrderedListPage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_ConceptPage.php
@@ -67,35 +67,5 @@
6868 return $result;
6969 }
7070
71 - /**
72 - * Format a list of wiki pages chunked by letter, either as a bullet
73 - * list or a columnar format, depending on the length.
74 - *
75 - * @param int $cutoff
76 - * @return string
77 - */
78 -// private function formatList( $cutoff = 6 ) {
79 -// $end = count( $this->diWikiPages );
80 -//
81 -// if ( $end > $this->limit ) {
82 -// if ( $this->until !== '' ) {
83 -// $start = 1;
84 -// } else {
85 -// $start = 0;
86 -// $end --;
87 -// }
88 -// } else {
89 -// $start = 0;
90 -// }
91 -//
92 -// if ( count ( $this->diWikiPages ) > $cutoff ) {
93 -// return $this->columnList( $start, $end, $this->diWikiPages );
94 -// } elseif ( count( $this->diWikiPages ) > 0 ) {
95 -// return $this->shortList( $start, $end, $this->diWikiPages );
96 -// } else {
97 -// return '';
98 -// }
99 -// }
100 -
10171 }
10272
Index: trunk/extensions/SemanticMediaWiki/includes/articlepages/SMW_OrderedListPage.php
@@ -76,8 +76,8 @@
7777
7878 wfProfileIn( __METHOD__ . ' (SMW)' );
7979
80 - $this->from = $wgRequest->getVal( 'from' );
81 - $this->until = $wgRequest->getVal( 'until' );
 80+ $this->from = $wgRequest->getVal( 'from', '' );
 81+ $this->until = $wgRequest->getVal( 'until', '' );
8282
8383 if ( $this->initParameters() ) {
8484 $wgOut->addHTML( "<br id=\"smwfootbr\"/>\n" . $this->getHtml() );