r108877 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108876‎ | r108877 | r108878 >
Date:23:26, 13 January 2012
Author:hashar
Status:reverted
Tags:
Comment:
Disable MWDebug tests for now

PHPUnit is too old on gallium so assertCount() is not recognized
The other two tests are broken for an unknown reason.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/debug/MWDebugTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/debug/MWDebugTest.php
@@ -7,6 +7,9 @@
88 MWDebug::clearLog();
99 }
1010
 11+ /**
 12+ * @group Broken
 13+ */
1114 function testAddLog() {
1215 MWDebug::log( 'logging a string' );
1316 $this->assertEquals( array( array(
@@ -18,6 +21,9 @@
1922 );
2023 }
2124
 25+ /**
 26+ * @group Broken
 27+ */
2228 function testAddWarning() {
2329 MWDebug::warning( 'Warning message' );
2430 $this->assertEquals( array( array(
@@ -29,6 +35,10 @@
3036 );
3137 }
3238
 39+ /**
 40+ * Broken on gallium which use an old PHPUnit version
 41+ * @group Broken
 42+ */
3343 function testAvoidDuplicateDeprecations() {
3444 MWDebug::deprecated( 'wfOldFunction', '1.0', 'component' );
3545 MWDebug::deprecated( 'wfOldFunction', '1.0', 'component' );
@@ -39,6 +49,10 @@
4050 );
4151 }
4252
 53+ /**
 54+ * Broken on gallium which use an old PHPUnit version
 55+ * @group Broken
 56+ */
4357 function testAvoidNonConsecutivesDuplicateDeprecations() {
4458 MWDebug::deprecated( 'wfOldFunction', '1.0', 'component' );
4559 MWDebug::warning( 'some warning' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r109034enable MWDebug tests...hashar13:56, 16 January 2012

Status & tagging log