r108822 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108821‎ | r108822 | r108823 >
Date:18:28, 13 January 2012
Author:siebrand
Status:reverted (Comments)
Tags:
Comment:
Return message instead of key.
Modified paths:
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
@@ -321,7 +321,7 @@
322322 public static function preventUnknownTranslations( Title $title, User $user, $action, &$result ) {
323323 $handle = new MessageHandle( $title );
324324 if ( $handle->isPageTranslation() && $action === 'edit' && !$handle->isValid() ) {
325 - $result = array( 'tpt-unknown-page' );
 325+ $result = array( wgMsg( 'tpt-unknown-page' ) );
326326 return false;
327327 }
328328

Follow-up revisions

RevisionCommit summaryAuthorDate
r108823Fix typo in r108822.siebrand18:31, 13 January 2012
r108848Revert r108822 and r108823. This fixed an API error message, but caused an is...siebrand21:15, 13 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   19:13, 13 January 2012

Was this supposed to fix API errors? This breaks non-API errors: http://translatewiki.net/sandwiki/i.php?title=Translations:Kfe&action=edit

Possibly related bug 29261.

#Comment by Siebrand (talk | contribs)   20:43, 13 January 2012

Yes, it was. Guess I'll have to find another solution.

Status & tagging log