r108814 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108813‎ | r108814 | r108815 >
Date:15:36, 13 January 2012
Author:rsterbin
Status:ok
Tags:aft 
Comment:
Put classes directly in html rather than adding them with jquery; Yoni thinks that change did not in fact fix any IE7 bugs, and there's a modest perfomance improvement without it
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js
@@ -116,9 +116,9 @@
117117 // C: Button fixed to right side
118118 if ( 'C' == linkBucket ) {
119119 var $fixedTab = $( '\
120 - <div id="articleFeedbackv5-fixedtab">\
121 - <div id="articleFeedbackv5-fixedtabbox">\
122 - <a href="#mw-articleFeedbackv5" id="articleFeedbackv5-fixedtablink"></a>\
 120+ <div id="articleFeedbackv5-fixedtab" class="articleFeedbackv5-fixedtab">\
 121+ <div id="articleFeedbackv5-fixedtabbox" class="articleFeedbackv5-fixedtabbox">\
 122+ <a href="#mw-articleFeedbackv5" id="articleFeedbackv5-fixedtablink" class="articleFeedbackv5-fixedtablink"></a>\
123123 </div>\
124124 </div>' );
125125 $fixedTab.find( '#articleFeedbackv5-fixedtablink' )
@@ -129,18 +129,15 @@
130130 clickFeedbackLink( $( e.target ) );
131131 } );
132132 $fixedTab.insertBefore( $aftDiv );
133 - $fixedTab.addClass( 'articleFeedbackv5-fixedtab' );
134 - $fixedTab.find( '#articleFeedbackv5-fixedtabbox' ).addClass( 'articleFeedbackv5-fixedtabbox' );
135 - $fixedTab.find( '#articleFeedbackv5-fixedtablink' ).addClass( 'articleFeedbackv5-fixedtablink' );
136133 $aftDiv.articleFeedbackv5( 'addToRemovalQueue', $fixedTab );
137134 }
138135
139136 // D: Button fixed to bottom right
140137 if ( 'D' == linkBucket ) {
141138 var $bottomRightTab = $( '\
142 - <div id="articleFeedbackv5-bottomrighttab">\
143 - <div id="articleFeedbackv5-bottomrighttabbox">\
144 - <a href="#mw-articleFeedbackv5" id="articleFeedbackv5-bottomrighttablink"></a>\
 139+ <div id="articleFeedbackv5-bottomrighttab" class="articleFeedbackv5-bottomrighttab">\
 140+ <div id="articleFeedbackv5-bottomrighttabbox" class="articleFeedbackv5-bottomrighttabbox">\
 141+ <a href="#mw-articleFeedbackv5" id="articleFeedbackv5-bottomrighttablink" class="articleFeedbackv5-bottomrighttablink"></a>\
145142 </div>\
146143 </div>' );
147144 $bottomRightTab.find( '#articleFeedbackv5-bottomrighttablink' )
@@ -151,9 +148,6 @@
152149 clickFeedbackLink( $( e.target ) );
153150 } );
154151 $bottomRightTab.insertBefore( $aftDiv );
155 - $bottomRightTab.addClass( 'articleFeedbackv5-bottomrighttab' );
156 - $bottomRightTab.find( '#articleFeedbackv5-bottomrighttabbox' ).addClass( 'articleFeedbackv5-bottomrighttabbox' );
157 - $bottomRightTab.find( '#articleFeedbackv5-bottomrighttablink' ).addClass( 'articleFeedbackv5-bottomrighttablink' );
158152 $aftDiv.articleFeedbackv5( 'addToRemovalQueue', $bottomRightTab );
159153 }
160154

Status & tagging log