r108799 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108798‎ | r108799 | r108800 >
Date:09:13, 13 January 2012
Author:laner
Status:ok
Tags:
Comment:
Actually fix the loop problem this time.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaController.php
@@ -168,8 +168,8 @@
169169 $zones = $this->novaConnection->describe_availability_zones();
170170 $zones = $zones->body->availabilityZoneInfo->item;
171171 foreach ( $zones as $zone ) {
172 - if ( $zones->zoneState == "available" ) {
173 - $this->availabilityZones["$zones->zoneName"] = $zone;
 172+ if ( $zone->zoneState == "available" ) {
 173+ $this->availabilityZones["$zone->zoneName"] = $zone;
174174 }
175175 }
176176 return $this->availabilityZones;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108797Fix a nasty infinite loop.laner08:56, 13 January 2012

Status & tagging log