r108795 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108794‎ | r108795 | r108796 >
Date:08:53, 13 January 2012
Author:laner
Status:resolved
Tags:
Comment:
Remove unneeded extra section.
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackManager.i18n.php (modified) (history)
  • /trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/special/SpecialNovaInstance.php
@@ -92,7 +92,7 @@
9393 'label-message' => 'openstackmanager-instancename',
9494 'validation-callback' => array( $this, 'validateText' ),
9595 'default' => '',
96 - 'section' => 'instance/info',
 96+ 'section' => 'info',
9797 'name' => 'instancename',
9898 );
9999
@@ -109,7 +109,7 @@
110110 $instanceInfo['instanceType'] = array(
111111 'type' => 'select',
112112 'label-message' => 'openstackmanager-instancetype',
113 - 'section' => 'instance/info',
 113+ 'section' => 'info',
114114 'options' => $instanceType_keys,
115115 'name' => 'instanceType',
116116 );
@@ -123,7 +123,7 @@
124124 }
125125 $instanceInfo['availabilityZone'] = array(
126126 'type' => 'select',
127 - 'section' => 'instance/info',
 127+ 'section' => 'info',
128128 'options' => $availabilityZone_keys,
129129 'label-message' => 'openstackmanager-availabilityzone',
130130 'name' => 'availabilityZone',
@@ -159,7 +159,7 @@
160160 }
161161 $instanceInfo['imageType'] = array(
162162 'type' => 'select',
163 - 'section' => 'instance/info',
 163+ 'section' => 'info',
164164 'options' => $image_keys,
165165 'default' => $default,
166166 'label-message' => 'openstackmanager-imagetype',
@@ -176,7 +176,7 @@
177177 # }
178178 # $instanceInfo['keypair'] = array(
179179 # 'type' => 'select',
180 - # 'section' => 'instance/info',
 180+ # 'section' => 'info',
181181 # 'options' => $keypair_keys,
182182 # 'label-message' => 'keypair',
183183 # );
@@ -189,7 +189,7 @@
190190 }
191191 $instanceInfo['domain'] = array(
192192 'type' => 'select',
193 - 'section' => 'instance/info',
 193+ 'section' => 'info',
194194 'options' => $domain_keys,
195195 'label-message' => 'openstackmanager-dnsdomain',
196196 'name' => 'domain',
@@ -209,7 +209,7 @@
210210 }
211211 $instanceInfo['groups'] = array(
212212 'type' => 'multiselect',
213 - 'section' => 'instance/info',
 213+ 'section' => 'info',
214214 'options' => $group_keys,
215215 'default' => $defaults,
216216 'label-message' => 'openstackmanager-securitygroups',
@@ -299,7 +299,7 @@
300300 if ( !$puppetinfo ) {
301301 $instanceInfo["warning"] = array(
302302 'type' => 'info',
303 - 'section' => "instance/puppetinfo",
 303+ 'section' => "puppetinfo",
304304 'default' => wfMsg( 'openstackmanager-createinstancepuppetwarning' ),
305305 );
306306 }
@@ -317,9 +317,9 @@
318318 $puppetgroupname = $puppetGroup->getName();
319319 $puppetgroupproject = $puppetGroup->getProject();
320320 if ( $puppetgroupproject ) {
321 - $section = 'instance/puppetinfo/project';
 321+ $section = 'puppetinfo/project';
322322 } else {
323 - $section = 'instance/puppetinfo/global';
 323+ $section = 'puppetinfo/global';
324324 }
325325 foreach ( $puppetGroup->getClasses() as $class ) {
326326 $classname = $class["name"];
Index: trunk/extensions/OpenStackManager/OpenStackManager.i18n.php
@@ -77,7 +77,6 @@
7878 'openstackmanager-dnsdomain' => 'DNS domain',
7979 'openstackmanager-puppetclasses' => 'Classes',
8080 'openstackmanager-novainstance-info' => 'Instance information',
81 - 'openstackmanager-novainstance-puppetinfo' => 'Puppet information',
8281 'openstackmanager-novainstance-project' => 'Project specific groups',
8382 'openstackmanager-novainstance-global' => 'Global groups',
8483

Follow-up revisions

RevisionCommit summaryAuthorDate
r108802Ugh. Removed the wrong message.laner09:19, 13 January 2012

Status & tagging log