r108771 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108770‎ | r108771 | r108772 >
Date:22:17, 12 January 2012
Author:brion
Status:ok
Tags:
Comment:
Revert r108764: doesn't appear to do what it says in the description, and no explanation why it's being done (presumably would just break searches again?)
Modified paths:
  • /trunk/phase3/includes/Export.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Export.php
@@ -476,7 +476,7 @@
477477 function openPage( $row ) {
478478 $out = " <page>\n";
479479 $title = Title::makeTitle( $row->page_namespace, $row->page_title );
480 - $out .= ' ' . Xml::elementClean( 'title', array(), $title->getPrefixedText() ) . "\n";
 480+ $out .= ' ' . Xml::elementClean( 'title', array(), self::canonicalTitle( $title ) ) . "\n";
481481 $out .= ' ' . Xml::element( 'ns', array(), strval( $row->page_namespace) ) . "\n";
482482 $out .= ' ' . Xml::element( 'id', array(), strval( $row->page_id ) ) . "\n";
483483 if ( $row->page_is_redirect ) {
@@ -521,12 +521,6 @@
522522
523523 $out .= $this->writeTimestamp( $row->rev_timestamp );
524524
525 - if ( $row->rev_sha1 ) {
526 - $out .= " " . Xml::element('sha1', null, strval($row->rev_sha1) ) . "\n";
527 - } else {
528 - $out .= " <sha1/>\n";
529 - }
530 -
531525 if ( $row->rev_deleted & Revision::DELETED_USER ) {
532526 $out .= " " . Xml::element( 'contributor', array( 'deleted' => 'deleted' ) ) . "\n";
533527 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108764This commit restores getPrefixedText() to the Title in the XML. This means i...diederik21:34, 12 January 2012

Status & tagging log