r108754 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108753‎ | r108754 | r108755 >
Date:20:34, 12 January 2012
Author:maxsem
Status:ok
Tags:
Comment:
Increased $wgMaxCoordinatesPerPage by 10 times and made it possible to have no limits
Modified paths:
  • /trunk/extensions/GeoData/CoordinatesParserFunction.php (modified) (history)
  • /trunk/extensions/GeoData/GeoData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GeoData/CoordinatesParserFunction.php
@@ -103,7 +103,7 @@
104104 private function applyCoord( Coord $coord ) {
105105 global $wgMaxCoordinatesPerPage, $wgContLang;
106106 $geoData = $this->output->geoData;
107 - if ( $geoData->getCount() >= $wgMaxCoordinatesPerPage ) {
 107+ if ( $wgMaxCoordinatesPerPage >= 0 && $geoData->getCount() >= $wgMaxCoordinatesPerPage ) {
108108 if ( $geoData->limitExceeded ) {
109109 return Status::newFatal( '' );
110110 }
Index: trunk/extensions/GeoData/GeoData.php
@@ -48,6 +48,6 @@
4949 $wgDefaultGlobe = 'earth';
5050
5151 /**
52 - * Maximum number of coordinates per page
 52+ * Maximum number of coordinates per page, -1 means no limit
5353 */
54 -$wgMaxCoordinatesPerPage = 50;
 54+$wgMaxCoordinatesPerPage = 500;

Status & tagging log