r108650 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108649‎ | r108650 | r108651 >
Date:18:53, 11 January 2012
Author:rmoen
Status:deferred
Tags:
Comment:
apply clearfix elements to feedback dashboard filters, tweak leaderboard markup for IE
Modified paths:
  • /trunk/extensions/MoodBar/SpecialFeedbackDashboard.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/SpecialFeedbackDashboard.php
@@ -112,7 +112,7 @@
113113 array( 'id' => 'fbd-filters-my-response', 'value' => '1', 'class' => 'fbd-filters-check' ) );
114114
115115 $myResponseFilter = $myResponseCheckbox. '<label for="fbd-filters-my-response" id="fbd-filters-type-my-response-label" class="fbd-filters-label">' .
116 - $myResponseMsg . '</label><br class="fbd-clearfix" />';
 116+ $myResponseMsg . '</label>';
117117 }
118118
119119 // Show unanswered filter
@@ -121,7 +121,7 @@
122122 array( 'id' => 'fbd-filters-show-unanswered', 'value' => '1', 'class' => 'fbd-filters-check' ) );
123123
124124 $showUnansweredFilter = $showUnansweredCheckbox . '<label for="fbd-filters-show-unanswered" id="fbd-filters-type-show-unanswered-label" class="fbd-filters-label">' .
125 - $showUnansweredMsg . '</label><br class="fbd-clearfix" />';
 125+ $showUnansweredMsg . '</label>';
126126
127127 $leaderBoardElement = self::buildLeaderBoardElement();
128128
@@ -156,8 +156,11 @@
157157 </fieldset>
158158 <label for="fbd-filters-username" class="fbd-filters-label">$usernameMsg</label>
159159 $usernameTextbox
 160+ <br class="fbd-clearfix" />
160161 $myResponseFilter
 162+ <br class="fbd-clearfix" />
161163 $showUnansweredFilter
 164+ <br class="fbd-clearfix" />
162165 <button type="submit" id="fbd-filters-set">$setFiltersMsg</button>
163166 </form>
164167 <a href="$whatIsURL" id="fbd-about">$whatIsMsg</a>
@@ -277,8 +280,8 @@
278281 foreach ( $topResponders as $row ) {
279282 $user = User::newFromRow( $row );
280283 if ( $user && !$user->isAnon() ) {
281 - $html .= '<li>' . Linker::userLink( $user->getId(), htmlspecialchars( $user->getName() ) ) .
282 - '<span>' . $wgLang->formatNum( intval( $row->number ) ) . '</span></li>';
 284+ $html .= '<li><span>' . $wgLang->formatNum( intval( $row->number ) ) . '</span>'
 285+ . Linker::userLink( $user->getId(), htmlspecialchars( $user->getName() ) ) . '</li>';
283286 }
284287 }
285288 }
Index: trunk/extensions/MoodBar/modules/ext.moodBar.dashboard/ext.moodBar.dashboard.css
@@ -110,6 +110,7 @@
111111 .fbd-leaderboard li span {
112112 float:right;
113113 color: #777777;
 114+ display:block
114115 }
115116
116117 .fbd-leaderboard-top-responders {

Status & tagging log