r108635 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108634‎ | r108635 | r108636 >
Date:16:57, 11 January 2012
Author:catrope
Status:ok
Tags:
Comment:
Fix double-escaping pointed out in r108506 CR.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/api/ApiViewFeedbackArticleFeedbackv5.php
@@ -196,20 +196,20 @@
197197 .$content
198198 .wfMessage( 'articlefeedbackv5-form-helpful-label' )->escaped()
199199 .Html::openElement( 'div', array( 'id' => 'aft5-feedback-tools' ) )
200 - .Html::element( 'h3', array(), wfMessage( 'articlefeedbackv5-form-tools-label' )->escaped() )
 200+ .Html::element( 'h3', array(), wfMessage( 'articlefeedbackv5-form-tools-label' )->text() )
201201 .Html::openElement( 'ul' )
202202 .($can_flag ? Html::rawElement( 'li', array(), Html::element( 'a', array(
203203 'id' => "aft5-hide-link-$id",
204204 'class' => 'aft5-hide-link'
205 - ), wfMessage( 'articlefeedbackv5-form-hide', $record[0]->af_hide_count )->escaped() ) ) : '' )
 205+ ), wfMessage( 'articlefeedbackv5-form-hide', $record[0]->af_hide_count )->text() ) ) : '' )
206206 .($can_hide ? Html::rawElement( 'li', array(), Html::element( 'a', array(
207207 'id' => "aft5-abuse-link-$id",
208208 'class' => 'aft5-abuse-link'
209 - ), wfMessage( 'articlefeedbackv5-form-abuse', $record[0]->af_abuse_count )->escaped() ) ) : '' )
 209+ ), wfMessage( 'articlefeedbackv5-form-abuse', $record[0]->af_abuse_count )->text() ) ) : '' )
210210 .($can_delete ? Html::rawElement( 'li', array(), Html::element( 'a', array(
211211 'id' => "aft5-delete-link-$id",
212212 'class' => 'aft5-delete-link'
213 - ), wfMessage( 'articlefeedbackv5-form-delete' )->escaped() ) ) : '' )
 213+ ), wfMessage( 'articlefeedbackv5-form-delete' )->text() ) ) : '' )
214214 .Html::closeElement( 'ul' )
215215 .Html::closeElement( 'div' )
216216 .Html::closeElement( 'div' )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108506AFTv5 fixes - consistent escaping of translations, fix typo in translations f...gregchiasson15:26, 10 January 2012

Status & tagging log