r108631 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108630‎ | r108631 | r108632 >
Date:15:48, 11 January 2012
Author:maxsem
Status:ok
Tags:
Comment:
Fixed and simplified tracking category
Modified paths:
  • /trunk/extensions/GeoData/CoordinatesParserFunction.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GeoData/CoordinatesParserFunction.php
@@ -70,7 +70,7 @@
7171 }
7272 }
7373
74 - $this->addCategory( wfMessage( 'geodata-broken-tags-category' ) );
 74+ $parser->addTrackingCategory( 'geodata-broken-tags-category' );
7575 $errorText = $this->errorText( $status );
7676 if ( $errorText == '<>' ) {
7777 // Error that doesn't require a message,
@@ -184,18 +184,6 @@
185185 }
186186
187187 /**
188 - * Adds a category to the output
189 - *
190 - * @param String|Message $name: Category name
191 - */
192 - private function addCategory( $name ) {
193 - if ( $name instanceof Message ) {
194 - $name = $name->inContentLanguage()->text();
195 - }
196 - $this->output->addCategory( $name, $this->parser->getTitle()->getText() );
197 - }
198 -
199 - /**
200188 * Returns wikitext of status error message in content language
201189 *
202190 * @param Status $s

Status & tagging log