r108575 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108574‎ | r108575 | r108576 >
Date:00:29, 11 January 2012
Author:bsitu
Status:ok
Tags:
Comment:
followup to -r108561 - code consistency
Modified paths:
  • /trunk/extensions/MoodBar/updateMoodBarFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/updateMoodBarFeedback.php
@@ -40,7 +40,7 @@
4141 array( 'MAX(mbfr_id) AS latest_mbfr_id', 'mbf_id' ),
4242 array( 'mbf_id=mbfr_mbf_id', 'mbf_latest_response' => 0, 'mbf_id > ' . $lastMbfId ),
4343 __METHOD__,
44 - array( 'ORDER BY' => 'mbf_id', 'GROUP BY' => 'mbf_id', "LIMIT $batchSize" )
 44+ array( 'ORDER BY' => 'mbf_id', 'GROUP BY' => 'mbf_id', 'LIMIT' => $batchSize )
4545 );
4646
4747 foreach ( $res as $row ) {
@@ -56,7 +56,7 @@
5757 $lastMbfId = $mbfId;
5858 }
5959
60 - $totalCount = $totalCount + $count;
 60+ $totalCount += $count;
6161
6262 $this->output( $count . "\n" );
6363 wfWaitForSlaves();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108561followup to -r108556 - make the maintenance script to process in batchsize at...bsitu23:31, 10 January 2012

Status & tagging log